We Keep Coding

C# How do I set specific binary bit to 0 or 1?

I've got four checkboxes linked to a hex value between 0x00 and 0x0F, so if you type in 0x0B which would be 1011 the check boxes would be checked, not checked, checked, checked. For this I used:
if ((controlByte.Item2 & 0x01) == 0x01)
{
control1 = true;
}
if ((controlByte.Item2 & 0x02) == 0x02)
{
control2 = true;
}
if ((controlByte.Item2 & 0x04) == 0x04)
{
control3 = true;
}
if ((controlByte.Item2 & 0x08) == 0x08)
{
control4 = true;
}
Next I want it to go the other direction, so as you click checkboxes the hex value will change.
If I have the current value 0x0B (1011) And click the first box I want it to return 0x0A (1010). My function will go over each checkbox and update the hex value as it goes. My current attempt looks like this:
if (checkbox1)
{
controlbyte = (byte)(controlbyte | 0x01);
}
else
{
controlbyte = (byte)(controlbyte ^ 0x01);
}
It looks like this toggles it, but when I run through all checkboxes it toggles ones I didn't click. Is there a better way to take 0x0B (1011) and just set one of the bits to 0 or 1?

( 1 << flag ) <--- change like this;
if ((controlByte.Item2 & (1 << flag)) == (1 << flag))
{
control[flag] = true;
}
//0x01 == 1 << 1;
//0x02 == 1 << 2;
//0x04 == 1 << 3;
//0x08 == 1 << 4;
//because it same like this:
if ((controlByte.Item2 & (1 << 1)) == (1 << 1))
{
control1 = true;
}
if ((controlByte.Item2 & (1 << 2)) == (1 << 2))
{
control2 = true;
}
if ((controlByte.Item2 & (1 << 3)) == (1 << 3))
{
control3 = true;
}
...
controlbyte = (byte)(controlbyte | (1 << 1));
controlbyte = (byte)(controlbyte ^ (1 << 1));

how do i decipher 4 byte data split them accordingly and assign them to a meaningful variable?

I have 4 byte data stream, I know at what bite I wanted to split them and assign them to a different variable. keeping in mind the data I receive is in hex format. let's say,
P_settings 4bytes p_timeout [6:0]
p_s_detected[7]
p_o_timeout [14:8]
p_o_timeout_set [15]
override_l_lvl [23:16]
l_b_lvl [31:24]
above P_settings is 4 bytes and I wanted to split them byte into bits like p_timeout [6:0] requires 7 bits of those 4 byte.
Currently, the implementation I have tried is..for just one byte split into bits.
var soch = ((b_data>> 0)& 0x7F ); if i want first 7 bits
how do I do it for 4 byte streams

Try code like this. You said input was a stream.
public class P_Settings
{
byte p_timeout; //[6:0]
Boolean p_s_detected; //[7]
byte p_o_timeout; // [14:8]
Boolean p_o_timeout_set; // [15]
byte override_l_lvl; //[23:16]
byte l_b_lvl; //[31:24]
public P_Settings(Stream data)
{
byte input = (byte)(data.ReadByte() & 0xff);
p_timeout = (byte)(input & 0x7F);
p_s_detected = (input & 0x80) == 0 ? false : true;
input = (byte)(data.ReadByte() & 0xff);
p_o_timeout = (byte)(input & 0x7F);
p_o_timeout_set = (input & 0x80) == 0 ? false : true;
override_l_lvl = (byte)(data.ReadByte() & 0xff);
l_b_lvl = (byte)(data.ReadByte() & 0xff);
}
}

SO it turns out it much easier that i thought..
1) separate them by single byte and put them in a buffer and & operate them individually and you will get the data. thanks for all the support.
**
byte input = (byte)( buffer[10]);//1 byte
var p_timeout = (byte)(input & 0x7F);
var p_s_detected = (input & 0x80) == 0 ? false : true;
input = (byte)( buffer[11]);//1 byte
var p_o_timeout = (byte)(input & 0x7F);
var p_o_timeout_set = (input & 0x80) == 0 ? false : true;
var override_l_lvl = (byte)(buffer[12] & 0xff);//1 byte
var l_b_lvl = (byte)(buffer[13] & 0xff); //1 byte
**

C# More simple way of converting an integer to a string in binary form without Convert.ToString method.?

I have a code that turns an integer to its binary representation, but I was wondering if there is a more simple or "easier" way of doing so. I know that there is a built-in method in C# that does this for you automatically, but that is not what I want to use.
This version loops over each o the 32-bit positions while writing ones and zeros and uses TrimStart to remove leading zeroes.
For example, converting the integer 10 to its string representation in
binary as "1010".
static string IntToBinary(int n)
{
char[] b = new char[32];
int pos = 31;
int i = 0;
while (i < 32) // Loops over each of the 32-bit positions while writing ones and zeros.
{
if ((n & (1 << i)) != 0)
{
b[pos] = '1';
}
else
{
b[pos] = '0';
}
pos--;
i++;
}
return new string(b).TrimStart('0'); // TrimStart removes leading zeroes.
}
static void Main()
{
Console.WriteLine(IntToBinary(300));
}

I suppose you could use a nibble lookup table:
static string[] nibbles = {
"0000", "0001", "0010", "0011",
"0100", "0101", "0110", "0111",
"1000", "1001", "1010", "1011",
"1100", "1101", "1110", "1111"
};
public static string IntToBinary(int n)
{
return
nibbles[(n >> 28) & 0xF] +
nibbles[(n >> 24) & 0xF] +
nibbles[(n >> 20) & 0xF] +
nibbles[(n >> 16) & 0xF] +
nibbles[(n >> 12) & 0xF] +
nibbles[(n >> 8) & 0xF] +
nibbles[(n >> 4) & 0xF] +
nibbles[(n >> 0) & 0xF]
.TrimStart('0');
}

Here is a simple LINQ implementation:
static string IntToBinary(int n)
{
return string.Concat(Enumerable.Range(0, 32)
.Select(i => (n & (1 << (31 - i))) != 0 ? '1' : '0')
.SkipWhile(ch => ch == '0'));
}
Another one using for loop:
static string IntToBinary(int n)
{
var chars = new char[32];
int start = chars.Length;
for (uint bits = (uint)n; bits != 0; bits >>= 1)
chars[--start] = (char)('0' + (bits & 1));
return new string(chars, start, chars.Length - start);
}

What is the right way to compare two strings and find the total qty of unequal chars?

I'm trying to compare two strings(Tx & Rx data) and find the quantity of unequal chars.
With the help of the following code, I managed to get the quantity,
string TxData = "00001111";
string RxData = "00000000";
int distorted = 0;
for (int i = 0; i < TxData.Length; i++)
{
if (TxData[i] != RxData[i])
distorted++;
}
Console.Write("Distorted Bits (qty) : {0}", distorted);
Result:
Distorted Bits (qty) : 4
But I'm very curious to know if there's any better way to do this task?
Thanks for your time...:)

If they're always the same length:
int distorted = TxData.Zip(RxData, (a,b) => a == b ? 0 : 1).Sum();

I like okrumnows answer by its simplisity, but assuming that you really already have bytes (or int) and don't need to convert them to string in the first place, you would probably be better of doing something like:
int myMethod(byte byte1, byte byte2)
{
//byte1 = Convert.ToByte("10010101",2);
//byte2 = Convert.ToByte("10011101",2);
byte xorvalue = (byte)( byte1 ^ byte2);
return NumberOfSetBits(xorvalue);
}
private static int NumberOfSetBits(uint i)
{
i = i - ((i >> 1) & 0x55555555);
i = (i & 0x33333333) + ((i >> 2) & 0x33333333);
return (((i + (i >> 4)) & 0x0F0F0F0F) * 0x01010101) >> 24;
}
This will be much faster.

CRC 16 for DECT in C#

There's a similar question asked and answered in C, but I'm struggling a bit to achieve the same thing in C#.
Generator Polynomial : x^16 + x^10 + x^8 + x^7 + x^3 + 1 which is equivalent to 10000010110001001 in binary.
I have 48 bits of data, and now I required to generate 16 bits of CRC, here's the code:
private bool[] MakeCRC(string BitString)
{
bool[] Res = new bool[17];
bool[] CRC = new bool[16];
int i;
bool DoInvert= false;
for (i = 0; i < 16; ++i) // Init before calculation
CRC[i] = false;
for (i = 0; i < BitString.Length; ++i)
{
if (BitString[i] == '1')
DoInvert = true ^ CRC[15];
//DoInvert = ('1' == BitString[i]) ^ CRC[15]; // XOR required?
CRC[15] = CRC[14];
CRC[14] = CRC[13];
CRC[13] = CRC[12];
CRC[12] = CRC[11];
CRC[11] = CRC[10];
CRC[10] = CRC[9] ^ DoInvert;
CRC[9] = CRC[8];
CRC[8] = CRC[7] ^ DoInvert;
CRC[7] = CRC[6] ^ DoInvert;
CRC[6] = CRC[5];
CRC[5] = CRC[4];
CRC[4] = CRC[3];
CRC[3] = CRC[2] ^ DoInvert;
CRC[2] = CRC[1];
CRC[1] = CRC[0];
CRC[0] = DoInvert;
}
for (i = 0; i < 16; ++i)
Res[15 - i] = CRC[i] ? true : false;
Res[16] = false; // Set string terminator
return (Res);
}
but the above code, gives me wrong output, please suggest me if there's any better way of doing it.
Edit:
Data(a0 to a47): 100011100011000001000001000100001000000000001000
Polynomial: 10000010110001001
Output Obtained: 0011 0100 1111 0111
Output Expected: 1100 1101 0100 1111
Thanks for your time.!

uncomment DoInvert = ('1' == BitString[i]) ^ CRC[15];
and remove the line above and it works.
Your replacement for the commented line is wrong. Right would be:
if (BitString[i] == '1')
DoInvert = true ^ CRC[15];
else
DoInvert = false ^ CRC[15];