We Keep Coding

Find all occurences of a value in a list

I am trying to get the number of how many times player.userID shows in a list but I can't seem to figure out how, I have searched the internet for an hour now.
class ConfigData
{
[JsonProperty(PropertyName = "Ban")]
public uint ban = 3;
[JsonProperty(PropertyName = "Kick")]
public uint kick = 2;
[JsonProperty(PropertyName = "Banned Message")]
public string kickMessage = "You are banned";
}
class StoredData
{
public List<ulong> Reports = new List<ulong>();
public List<ulong> Banned = new List<ulong>();
public List<ulong> Kicked = new List<ulong>();
}
void OnPlayerConnected(BasePlayer player)
{
int count = storedData.Reports.Count(reportedID => reportedID == player.userID);
Puts($"{player.userID} has {count} reports");
if (count >= configData.ban)
{
storedData.Banned.Add(player.userID);
SaveData();
return;
}
if (storedData.Banned.Contains(player.userID))
{
Network.Net.sv.Kick(player.net.connection, rust.QuoteSafe(configData.kickMessage));
return;
}
else
{
return;
}
}
I can post the full code if needed.

The Count method accepts a lambda that tells it the condition on which to count.
Since your reports are just a list of user IDs, all you need to do is:
int count = storedData.Reports.Count(reportedID => reportedID == player.userID);
if (count >= configData.ban) // NOTE: changed this to >=
{
...
}
As a side note, if it was a list of objects instead, and you wanted to compare to a property named someProperty, then it would be:
report => report.someProperty == player.userID.
A lambda is just a shorthand for a function; the part before the => is the parameter list (here, it just accepts a single parameter - the current element of storedData.Reports). The parameter name is arbitrary (your choice).
The part behind the => is the function body, with implicit return, so
reportedID == player.userID is like
{ return reportedID == player.userID; }.
The Count method basically walks through the IDs in Reports, and for each one, it asks the lambda if it should count it or not, by passing that ID to the lambda, and checking if the lambda returns true or false.
P.S.
In your code it says:
if (!storedData.Banned.Contains(player.userID)) { /* kick */ }
Are you sure you want to kick the players that are not in the banned list? Check the logic that relates to kicking/banning (maybe do some tests), it doesn't look quite right to me.

Filtering a collection by property in object in nested collection

I have three classes:
public class Error
{
public List<ErrorOccurrenceDetails> Occurrences { get; set; }
}
public class ErrorOccurrenceDetails
{
public Dictionary<DateTime, ErrorTime> Times { get; set; }
}
public class ErrorTime
{
public string Version { get; set; }
}
There's an Error that has multiple Occurrences that happened in different Times. Each time can occur on a different Version.
I have a list of Errors. I need to remove errors which do not have provided version, for example if user only wants to see errors in version "1.0", other versions (such as "1.1", "1.2") need to be removed. However, if an error has occurrences on version "1.0" AND others, filter should delete only bad occurrences, not entire error.
I tried to do it this way:
private IList<Error> errors;
private void Filter(string filterVersion)
{
var errorsToRemove = new Dictionary<int, ErrorOccurrenceDetails>();
foreach (Error error in this.errors)
{
int index = this.errors.IndexOf(error);
var listOfSearchedItems = error.Occurences.ToList();
listOfSearchedItems.RemoveAll(x => x.Times.Values.Any(y => y.Version != filterVersion));
var errorOccurences = error.Occurences.Except(listOfSearchedItems).ToList();
if (errorsToRemove.ContainsKey(index))
{
errorsToRemove[index].AddRange(errorOccurences);
}
else
{
errorsToRemove.Add(index, errorOccurences);
}
}
}
I'm trying to put all errors that need to be removed into errorsToRemove dictionary, where key is error index in this.errors, and value is a list of occurrences not on searched version.
It kinda works, but sometimes doesn't remove bad versions and causes some correct versions to also be removed, so there is a hole I haven't noticed.
Sample error list in this fiddle: https://dotnetfiddle.net/Kxq50i

Based on Heinzi's answer I decided to use a much simpler approach. I think I wanted to avoid Collection was modified; enumeration operation may not execute exception at all costs and started doing stupid things.
private IList<Error> errors;
private static void Filter(string filterVersion)
{
for (int index = 0; index < errors.Count; index++)
{
Error error = errors[index];
foreach (var occurrence in error.Occurrences)
{
var toRemove = occurrence.Times.Keys.Where(key => occurrence.Times[key].Version != filterVersion).ToList();
foreach (var key in toRemove)
{
occurrence.Times.Remove(key);
}
if (occurrence.Times.Count == 0)
{
errors[index] = null; // not deleted to prevent index shift, null is hidden in UI
}
}
}
}
The solution is updated in this fiddle.

The reason might be the following lines which might cause the items of the original error.Occurences to be removed:
var listOfSearchedItems = error.Occurences.ToList();
listOfSearchedItems.RemoveAll(x => x.Times.Values.Any(y => y.Version != filterVersion));
Try replacing those 2 lines with the one below:
var listOfSearchedItems = error.Occurences.Where(x => x.Times.Values.Any(y => y.Version == filterVersion)); // Note: Here we also replaced the "!=" with "=="

When using Linq, it is easier to think in terms of what to include rather than what you want to remove and write your code that way. For example:
private static IList<Error> Filter(string filterVersion)
{
var filtered = errors.Where(error => error.Occurrences.Any(occurrence => occurrence.Times.Any(kvp => kvp.Value.Version == filterVersion)))
.Select(error =>
{
return new Error
{
Occurrences = error.Occurrences
.Where(occurrence => occurrence.Times.Any(kvp => kvp.Value.Version == filterVersion))
.Select(occurrence =>
{
return new ErrorOccurrenceDetails
{
Times = new Dictionary<DateTime, ErrorTime>(occurrence.Times.Where(kvp => kvp.Value.Version == filterVersion))
};
})
.ToList()
};
})
.ToList();
return filtered;
}
Another possible benefit of this approach is that you are not modifying your original data, so you can apply different filters without having to re-read it.

Is there a way to create this report by Looping over the list of dates?

This is for a .net core 3.1 application, using Blazor for front end.
I have a list of dates that I need to take, and then build an "analysis" report using those dates. The analysis basically needs to look at the dates and tell me how many dates fall on each day of the week, and also how many dates are in each month of the year. This fis for an Human Resources application where they are tracking employee absences.
I have a List that I've built, and I'm passing it into a method that then performs an analysis.
public class DateHourResponseModel
{
public DateTime Date { get; set; }
public int Hours { get; set; }
}
I figured I could then take that list, and create a list of "Responses", each for a different day of the week, and month of the year. I figured for "Type" I could just use the DateTime.DayOfWeek, DateTime.Month and get an into (0-6 for day of week, 1-12 for month) which is why I have the "IsMonth" bool on there.
public class AbsenceAnalysisResponse
{
public int Type { get; set; }
public bool IsMonth { get; set; }
public int Count { get; set; }
public int Hours { get; set; }
}
And This class, which is just a list of the above:
public class AbsenceAnalysis
{
public List<AbsenceAnalysisResponse> Responses { get; set; }
}
My question is: Is there a way to build this analysis report by doing a foreach on the list of dates that I start with? I haven't figured out a way to create this list without doing something like this:
var analysisResponses = new List<AbsenceAnalysisResponse>
{
new AbsenceAnalysisResponse
{
Type = 0,
IsMonth = false,
Count = dateHourModel.Count(x => (int)x.Date.DayOfWeek == 0),
Hours = dateHourModel.Where(x => (int)x.Date.DayOfWeek == 0).Sum(x => x.Hours)
},
I feel like an idiot because I know there has got to be a more elegant way of doing this, and maybe the problem is how I'm approaching it. I have the analysis working and displaying on the front end but I absolutely hate how I'm creating the list of "responses". I'm still pretty green behind the ears with this, and I don't know if I just haven't been searching the right questions online or what, but I haven't found anything where someone is doing something similar. Thanks for any help, and please let me know if there is any information I need to provide.

Something like this should work:
var models = new List<DateHourResponseModel>(); //Should be a filled list, not empty like this
var modelMap = new Dictionary<(int, bool), AbsenceAnalysisResponse>();
foreach (DateHourResponseModel dateHour in models)
{
Add(type: (int)dateHour.Date.DayOfWeek, isMonth: false);
Add(type: dateHour.Date.Month, isMonth: true);
void Add(int type, bool isMonth)
{
(int, bool) key = (type, isMonth);
//Try to get existing responses
if(!modelMap.TryGetValue(key, out AbsenceAnalysisResponse response))
{
//Create if first time adding to it
modelMap[key] = response = new AbsenceAnalysisResponse
{
Type = type,
IsMonth = isMonth,
Count = 0,
Hours = 0
};
}
response.Count += 1;
response.Hours += dateHour.Hours;
}
}
//convert to list, can order if needed with .OrderBy()
List<AbsenceAnalysisResponse> analysisResponses = modelMap.Values.ToList();
The idea would be to loop through each model and add/modify to the list. Instead of searching through the list, a dictionary can be used with a unique key. In this case type + isMonth, in tuple form, but it could also be a string "{type}-{isMonth}" or something. If the key is not found then it will be created, otherwise just modified. At the end, turn the Dictionary into a list of its values. There are other ways of doing this, but this should be a good approach

Just wanted to post another solution I found while tinkering with this. I really liked Gekctek's answer, and used that initially. I think this one might be slightly more readable? Happy to receive any feedback.
private AbsenceAnalysis GetAbsenceAnalysisFromData(List<DateHourResponseModel> dateHourModel)
{
var analysis = new List<AbsenceAnalysisResponse>();
foreach (var data in dateHourModel)
{
var week = analysis.FirstOrDefault(x =>
x.Type == (int)data.Date.DayOfWeek && x.IsMonth == false);
var month = analysis.FirstOrDefault(x =>
x.Type == (int)data.Date.Month && x.IsMonth == true);
if (week == null)
{
week = new AbsenceAnalysisResponse
{
Count = 0,
Hours = 0,
IsMonth = false,
Type = (int)data.Date.DayOfWeek
};
analysis.Add(week);
}
if (month == null)
{
month = new AbsenceAnalysisResponse
{
Count = 0,
Hours = 0,
IsMonth = true,
Type = data.Date.Month
};
analysis.Add(month);
}
week.Count += 1;
week.Hours += data.Hours;
month.Count += 1;
month.Hours += data.Hours;
}

Search in Silverlight c# for name recognition

I have a silverlight app using Prism practices; the current code does a search by first name or last name or gender. regaring the names, I would like to alter the code to somethng like 3 characters because now it is searching as long as one character is found the name will display so you can see the issue, can I adjust the code here to only select those with a 3 character match? lets leave alone the issue of a name with less than 3 but we can allow anything there then.
using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
namespace PBM.Web.Classes
{
public class Search
{
public static IQueryable<Patient> GetSearchQueryPatient(IQueryable<Patient> pSearchQuery, Patient pPatient)
{
if (!string.IsNullOrEmpty(pPatient.FirstName))
{
pSearchQuery = pSearchQuery.Where(item => item.FirstName.Contains(pPatient.FirstName));
}
if (!string.IsNullOrEmpty(pPatient.LastName))
{
pSearchQuery = pSearchQuery.Where(item => item.LastName.Contains(pPatient.LastName));
}
if (pPatient.Gender.HasValue && pPatient.Gender.Value > 0)
{
pSearchQuery = pSearchQuery.Where(item => item.Gender.Value == pPatient.Gender.Value);
}
pSearchQuery = pSearchQuery.OrderBy(item => item.FirstName).ThenBy(item => item.LastName);
return pSearchQuery;
}
}
}

If I've read your requirement and sample code correctly, simply add a length check to your tests should work:
if (!string.IsNullOrEmpty(pPatient.FirstName) && pPatient.FirstName.Length > 2)
{
pSearchQuery = pSearchQuery.Where(item => item.FirstName.Contains(pPatient.FirstName));
}
It does mean that if the name is less than 3 characters it won't match at all, so what you want to do is then check if this search returned anything and if not do the simple any length search:
if (!string.IsNullOrEmpty(pPatient.FirstName))
{
// First look for a 3 or more character match
if (pPatient.FirstName.Length > 2)
{
pSearchQuery = pSearchQuery.Where(item => item.FirstName.Contains(pPatient.FirstName));
}
// If didn't find anything do the simple search
if (!pSearchQuery.Any())
{
pSearchQuery = pSearchQuery.Where(item => item.FirstName.Contains(pPatient.FirstName));
}
}

Extending Telerik client template column and getting the values passed through

I am using the latest version Telerik MVC controls. I am using ASP.NET MVC 3 with razor.
I have a grid that lists all of my grant applications. I am wanting to use a grid that loads these grant applications via AJAX. I also need to create a client template column that has action links. These action links can vary depending on the state of each grant application.
I worked through the article at: http://gedgei.wordpress.com/2011/07/02/telerik-mvc-grid-actionlink-column/. I implemented the code as is and it works, I can create a client template column with a link in it. In my scenario I need to be able to pass in 2 parameters to the helper method, like:
column.ActionLink("Open", "Edit", "GrantApplication", item => new { id = item.Id, applicationStateId = item.GrantApplicationStateType.Id });
How I eventually implement this method in the end will change, but for now I am playing with these 2 input parameters to see how they are passed through and how I can retrieve them in the helper method.
The first question that I have regarding the article, why does the writer do the following:
var builder = factory.Template(x =>
{
var actionUrl = urlHelper.Action(action, controller, routeValues.Compile().Invoke(x));
return string.Format(#"{1}", actionUrl, linkText);
});
I can only assume that this is the server side template that is created? But nothing displays in the grid, so how do I skip this part and go directly to the client template (this is what I actually need).
The following part is also confusing because when the first parameter (id) check comes through then it is of type ParameterExpression so it goes into the true part of the if, but when the second parameter (grant application state id) comes in then it is of another type (not sure what) so then it goes into the false part of the if statement:
switch (argument.NodeType)
{
case ExpressionType.Constant:
value = ((ConstantExpression)argument).Value;
break;
case ExpressionType.MemberAccess:
MemberExpression memberExpression = (MemberExpression)argument;
if (memberExpression.Expression is ParameterExpression)
value = string.Format("<#= {0} #>", memberExpression.Member.Name);
else
value = GetValue(memberExpression);
break;
default:
throw new InvalidOperationException("Unknown expression type!");
}
When the second paramenter values goes into the false part of the if statement it fails here:
value = GetValue(memberExpression);
..and gives the following error message which I have no idea what it is:
variable 'item' of type MyProject.ViewModels.GrantApplicationListViewModel' referenced from scope '', but it is not defined
Here is my view model:
public class GrantApplicationListViewModel
{
public int Id { get; set; }
public string FirstName { get; set; }
public string LastName { get; set; }
public string FullNameDisplay
{
get { return FirstName + " " + LastName; }
}
public DateTime CreatedDate { get; set; }
public GrantApplicationStateType GrantApplicationStateType { get; set; }
}
Here is my partial grid declaration in my view:
#(Html.Telerik()
.Grid<GrantApplicationListViewModel>()
.Name("grdGrantApplications")
.Columns(column =>
{
column.Bound(x => x.Id)
.ClientTemplate(
"<label class=\"reference-number\">" + "<#= Id #>" + "</label>"
)
.Title("Ref #")
.Width(70);
column.Bound(x => x.FullNameDisplay)
.Title("Owner")
.Width(200);
column.Bound(x => x.GrantApplicationStateType.Name)
.Title("Status")
.Width(90);
//column.ActionLink("Edit", "Edit", "GrantApplication", item => new { id = item.Id });
column.ActionLink("Open", "Edit", "GrantApplication", item => new { id = item.Id, applicationStateId = item.GrantApplicationStateType.Id });
})
.DataBinding(dataBinding => dataBinding.Ajax().Select("AjaxGrantApplicationsBinding", "Home"))
.Pageable(paging => paging.PageSize(30))
.TableHtmlAttributes(new { #class = "telerik-grid" })
)
What I am trying to achieve with the above is code is something to the effect of:
if grant application id = 1
then return Edit link and View link
else
then return Details link
How would I do the above? Is the code in that article the only way to do it? Isn't there a more simplar way? I did Google and couldn't find much help on what I want to do. Has any one else come across something like this?

If all you want is the client template to display different content based on the application id, it would be simpler to just put a conditional in the client template.
column.Bound(x => x.Id)
.ClientTemplate("<# if (Id == 1 ) { #> Edit Link and View Link <# } else { #> Details Link <# } #>");
The Edit, View, and Details links would be put in the same way they are put in without the conditional.