I'm trying to use a left join to set the plot.jobs row to 0 when there isn't a match found in the booking table (the check is plot.plot_id = booking.plot_id).
However I keep getting the following error message:
An exception of type 'MySql.Data.MySqlClient.MySqlException' occurred
in MySql.Data.dll but was not handled in user code Additional
information: You have an error in your SQL syntax; check the manual
that corresponds to your MySQL server version for the right syntax to
use near 'FROM plot LEFT JOIN booking ON plot.plot_id =
booking.plot_id WHERE plot.plot_id' at line 1.
I was following this template here:
UPDATE <Table2>
SET Count = 0
FROM <Table2>
LEFT JOIN <Table1>
ON <Table2>.<JoinColumn> = <Table1>.<JoinColumn>
WHERE <Table1>.<JoinColumn> IS NULL
This is my code so far:
query = "UPDATE plot SET jobs = #jobCount WHERE plot_id = #plotID AND postcode='MK';";
query += "UPDATE plot " +
"SET jobs = 0 " +
"FROM plot " +
"LEFT JOIN booking " +
"ON plot.plot_id = booking.plot_id " +
"WHERE plot.plot_id IS NULL";
cmd = new MySqlCommand(query, _connection);
You are attempting to use the SQL Server syntax for UPDATE statements on MySQL. This doesn't work.
The UPDATE-syntax of MySQL is:
UPDATE [LOW_PRIORITY] [IGNORE] table_reference
SET col_name1={expr1|DEFAULT} [, col_name2={expr2|DEFAULT}] ...
[WHERE where_condition]
[ORDER BY ...]
[LIMIT row_count]
Where table_reference is defined with the JOIN-syntax.
Your query should be something like:
query += "UPDATE plot " +
"LEFT JOIN booking " +
"ON plot.plot_id = booking.plot_id " +
"SET jobs = 0 " +
"WHERE plot.plot_id IS NULL";
I am wondering if you don't mean: WHERE booking.plot_id IS NULL
Your syntax isn't quite right for MySQL. Do your LEFT JOIN before SET
Something like this should work (Note: this hasn't been tested).
query += "UPDATE plot p" +
"LEFT JOIN booking b" +
"ON p.plot_id = b.plot_id " +
"SET jobs = 0 " +
"WHERE p.plot_id IS NULL";
You are attempting to update the plot table setting jobs equal to zero when plot_id is null? What is the point of the join in this case? You are attempting to join records based on a null value which seems highly invalid, and you're not using the joined table booking for anything. I recommend removing the join and the from statement is not valid in an update as Saggio mentioned.
query = "UPDATE plot SET jobs = #jobCount WHERE plot_id = #plotID AND postcode='MK';";
query +="UPDATE plot " +
"SET jobs = 0 " +
"LEFT JOIN booking ON plot.plot_id = booking.plot_id" +
"WHERE booking.plot_id IS NULL;";
cmd = new MySqlCommand(query, _connection);
Related
I have three tables, one holds a list of available products with relevant details such as product price, the other holds orders and the last holds specific order details including the items purchased in an order.
I am trying to create a query to calculate the total price of an order by linking the two of the tables with an inner join and then updating the order table with the value. The code I have written contains syntax errors, being a novice I have probably made an obvious mistake but any help would be appreciated.
"SELECT Sum(ProductTable.prodPrice) AS Total, OrderDetailTable.orderID " +
"FROM ProductTable INNER JOIN OrderDetailTable " +
"ON ProductTable.prodID = OrderDetailTable.prodID " +
"GROUP BY OrderDetailTable.orderID " +
"HAVING OrderDetailTable.orderID = ? " +
"UPDATE OrderTable " +
"SET " +
"totalPrice = Total " +
"WHERE OrderTable.orderID = ? ";
I am using Access.
I also forgot to mention that the ? is represented using a Dataview parameter
pc.Add(new Parameter("?", TypeCode.Int32, basketId.ToString()));
EDIT: Using PaqoGomez's suggestion to declare Total as a value I now get the error : Syntax error (missing operator) in query expression '0WHERE OrderTable.orderID = ?'.
Comment made before OP described this as MS Access:
Haven't tried this but you had the Select and update the wrong way round. This should be quite close. Its been a while for me but you may need to change the FROM clause to reference the table you are updating and INNER JOIN the sub-select instead of the WHERE clause.
"UPDATE OrderTable " +
"SET totalPrice = Sum(ProductTable.prodPrice)" +
"FROM (" +
"SELECT OrderDetailTable.orderID, Sum(ProductTable.prodPrice)" +
"FROM ProductTable INNER JOIN OrderDetailTable " +
"ON ProductTable.prodID = OrderDetailTable.prodID " +
"GROUP BY OrderDetailTable.orderID " +
") x" +
"WHERE x.orderID = OrderTable.OrderId"
UPDATE :
Based on OPs update regarding MS Access you can do an update with a sub-query, but I think it depends on the version of MS Access you are using and how you do it. Posts below seem to indicate it's quite problematic:
SQL Subqueries (Microsoft Access SQL)
How do I perform update query with subquery in Access?
Can It Be Done - Access 2007 SQL Update Query Using a Subquery?
By declaring a variable you can save the total value so that you can use it in the later update.
declare #Total int;
SELECT #Total = Sum(ProductTable.prodPrice)
//...
"SET " +
"totalPrice = #Total "
You dont mention which database platform you are using, I'm assuming MSSQL, other platforms would require a slightly different syntax.
You might also be interested to know that if you use the # symbol you can have a multiline string. This would allow you to avoid the concatenation that you are doing. eg.
var sql = #"some
sql
string"
I am c# beginner and hopefully get a help here.
I am not using SQL Server but just a query put in c# as shown below:
SqlCommand custcmd = new SqlCommand("SELECT customer.customerid, warehouse.warehouseNo, warehouse.qty_goods, warehouse.qty_slack, warehouse.std_weight, (qty_goods+qty_slack)*std_weight/1000 AS Total
FROM Customer
INNER JOIN warehouse WHERE customer.customerid BETWEEN" + "textbox1.text" + "AND" + "textbox2.text", myconnection)
An error is shown "Incorrect syntax near WHERE"
Can anyone please comment and help?
Thank in advance
BETWEEN" + "textbox1.text" + "AND" + "textbox2.text"
if you put 1 and 3 in textbox1 and textbox2 it will produce
BETWEEN1AND3
so here is a error
DO:
BETWEEN " + "textbox1.text" + " AND " + "textbox2.text"
Or better:
string.Format("SELECT customer.customerid, warehouse.warehouseNo, warehouse.qty_goods, warehouse.qty_slack, warehouse.std_weight, (qty_goods+qty_slack)*std_weight/1000 AS Total
FROM Customer INNER JOIN warehouse WHERE customer.customerid BETWEEN {0} AND {1}", textbox1.Text,textbox2.Text)
using String.Format will prevent you from making such mistakes, because you see better what will be produced as query
After INNER JOIN warehouse you should add condition ON to link tables for example
INNER JOIN warehouse ON customer.<field> = warehouse.<field>
It is the reason of the error "Incorrect syntax near WHERE" but also you should change WHERE statement according to the #wudzik's answer
So I'm retrieving data from the database using odbc. One of my fields, which was causing the problem, is AutoNumber. In my query when I use, '" convert.toint64(empid)"', I get an error of data type missmatch. But when I used parameter, it worked perfectly. Can someone tell me what is the difference. As far as I know, AutoNumber is a long integer and long int is 64, right?
here are both of my queries:
string cmdText = "SELECT p.projID, p.projName, a.wageperday " +
"FROM ((projects p INNER JOIN assigns a ON p.projID = a.projname) " +
"INNER JOIN empos e ON a.employeeID= e.ID) " +
"WHERE a.employeeID = ?";
OdbcCommand assignslist = new OdbcCommand(cmdText, _connection);
assignslist.Parameters.AddWithValue("#empID", empid);
OdbcDataReader readassigns = assignslist.ExecuteReader();
GridView1.DataSource = readassigns;
GridView1.DataBind();
(this one works fine)
string cmdText = "SELECT p.projID, p.projName, a.wageperday " +
"FROM ((projects p INNER JOIN assigns a ON p.projID = a.projname) " +
"INNER JOIN empos e ON a.employeeID= e.ID) " +
"WHERE a.employeeID = '" + convert.toint64( empid ) + "';
OdbcCommand assignslist = new OdbcCommand(cmdText, _connection);
OdbcDataReader readassigns = assignslist.ExecuteReader();
GridView1.DataSource = readassigns;
GridView1.DataBind();
for this one, i get an error even if I removed the conversion, I get an error.
One more question, I don't understand INNER JOIN perfectly and the above code was from a user here who helped me. I don't understand why did he use "FROM ((projects p INNER JOIN assigns a ON p.projID = a.projname) " +
"INNER JOIN empos e ON a.employeeID= e.ID)"
two brackets -- I mean a bracket inside a bracket. And if I wanna join a 4th or 5th table do I have to put it inside a bracket aside from the main bracket? An example would be much appreciated!
If a.employeeID is a number then your problem are the quotes and the concatenation of a number to a string.
"WHERE a.employeeID = " + convert.toint64(empid).ToString()
but this make no sense because you have a string to build so, you could simply write
"WHERE a.employeeID = " + empid.ToString();
however use always the parameterized query. That is the correct way to go.
A parameterized query allows the Framework code to pass the parameters with the correct format and you don't have to worry about quoting values, format of dates and decimal separators. (And last but not least, you avoid any possibilities of Sql Injection)
For the second part of your question, JOIN is used to put togheter data from two tables, when you have more than one JOIN the parenthesys help to understand how the grouping from the tables are perfomed. First the data from projects and assigns are grouped together following the rules of the INNER JOIN then the resulting set of data is joined with the data from the employee table following the rules of the second join.
In your second query, instead of using convert.toint64( empid ) try using empid.ToString():
"WHERE a.employeeID = " + empid.ToString();
The error you were receiving was due to the fact that you were trying to concatenate a string with an integer.
With regards to the INNER JOINs you are using, the use of the brackets is dependant upon the database you are using. In most cases, you will not need the brackets at all and they can be removed without any issue, so you could rewrite the query to:
string cmdText = "SELECT p.projID, p.projName, a.wageperday " +
"FROM projects p " +
"INNER JOIN assigns a ON p.projID = a.projname " +
"INNER JOIN empos e ON a.employeeID = e.ID " +
"WHERE a.employeeID = " empid.ToString();
You're trying to add a string and an integer, which isn't allowed automatically. You'd have to convert the number to a string first, like this:
"WHERE a.employeeID = '" + empid.ToString() + "';
But, using parameters is the better way for other reasons (best habit to be in, to avoid SQL-injection attacks, etc.).
Here's what needs to be done:
Match 2 fields from different tables in SQL Server( done ), update fields in table1 where table1.field1 = table2.field2 (problem, it just updates all the records in the table)
Here's what I have , where tempTableName is a table imported to SQL Server for the purpose of the query:
"UPDATE Table1 SET Table1.fieldN ='" + DateTime.Now.DayOfYear + "' FROM " + tempTableName + " CROSS JOIN Table1 WHERE (" + tempTableName + ".fieldX = Table1.fieldY)"
Here's what I've figured out:
everything after the FROM is useless as far as actual functionality is concerned, it runs the query but the results are not "linked" in any way to the actual UPDATE statement
To sum up :
The query I've figured out updates all records in table1, I need the query to update only the rows matched by the query after FROM
PS. Forgive me if this seems trivial and that I haven't done research but the fact of the matter is that 2 weeks ago I'd never even heard of SQL and have relied heavily on SO for direction and advice.
Your CROSS JOIN should be an INNER JOIN instead.
"UPDATE t1
SET fieldN ='" + DateTime.Now.DayOfYear + "'
FROM " + tempTableName + " t2 INNER JOIN Table1 t1 ON t1.fieldy = t2.fieldx"
So i learned how to do a bulk insert using data from one table as the userId from another table. Now i tried to do the same thing but i have a SQL(ite) error. I took a guess at the syntax and i got it wrong. After i bulk insert into the subscription i want to add 1 to each of the users media count. I have a left join error. How do i correct it?
-edit- I haven't solve this yet. Please help.
NOTE: I am using sqlite ATM but I am switching to mysql or MS sql
void updateMediaForSubscribers(long userId, long mediaId, Media_Base.Catagory cat, DateTime currentDate)
{
command.CommandText =
"INSERT INTO user_media_subscription (recipientId, mediaId, catagory) " +
"SELECT watcher, #mediaId, #category " +
"FROM user_watch WHERE watched=#watched;";
command.Parameters.Add("#mediaId", DbType.Int64).Value = mediaId;
command.Parameters.Add("#category", DbType.Int64).Value = cat;
command.Parameters.Add("#watched", DbType.Int64).Value = userId;
command.ExecuteNonQuery();
//near "LEFT": syntax error
command.CommandText =
"UPDATE user_data SET mediaMsgCount=mediaMsgCount+1 " +
"LEFT JOIN user_watch AS w ON w.watcher=user_data.userId " +
"WHERE w.watched=#watched;";
command.Parameters.Add("#watched", DbType.Int64).Value = userId;
command.ExecuteNonQuery();
}
UPDATE user_data
SET mediaMsgCount=mediaMsgCount+1
LEFT JOIN user_watch AS w ON w.watcher=user_data.userId
WHERE w.watched=#watched
Looks like it won't work to me, because you're joining in an UPDATE query but without a "FROM" clause, have you tried:
UPDATE u
SET u.mediaMsgCount = u.mediaMsgCount+1
FROM user_data u
LEFT JOIN user_watch AS w ON w.watcher=u.userId
WHERE w.watched=#watched
UPDATE user_data
SET mediaMsgCount = u.mediaMsgCount + 1
FROM user_data u LEFT OUTER JOIN user_watch w ON w.watcher = u.userId
WHERE w.watched=#watched
Honestly, I'm not really sure why you're using a left outer join since the update is dependant on user_watch... might want to change the "LEFT OUTER JOIN" to an "INNER JOIN".
Also, its a good idea to prefix your table name with the owner, I.E. dbo.user_data ... if you dont do that then sql server has to do a lookup.