We Keep Coding

How can I only code this once and replicate c#

I am new to C# and classes. I was testing on making a datagridview where the user can right click and a contextmenustrip pops. Now my question is the following.
I made my code to add the text to the textbox and increase the textbox if it is not empty.With help from this post.
private void TsmItem_Click(object sender, EventArgs e)
{
int rowindex = dgvResults.CurrentCell.RowIndex;
int columnindex = dgvResults.CurrentCell.ColumnIndex;
double resultText;
if (string.IsNullOrEmpty(Textbox.Text))
{
Textbox.Text = dgvResults.Rows[rowindex].Cells[columnindex].Value.ToString();
}
else
{
string selectedCell;
selectedCell = dgvResults.Rows[rowindex].Cells[columnindex].Value.ToString();
ResultText = Convert.ToDouble(Textbox.Text) + Convert.ToDouble(selectedCell);
Textbox.Text = Convert.ToString(ResultText);
}
}
Is there a way to only have this code only 1 time and call it every time I need it. So that I only have to change the textboxes.Text? Otherwise I need to copy and paste this code more than 10 times.
What I tried
private void TsmItem_Click(object sender, EventArgs e)
{
Textbox.Text = RightMouseClick(Textbox.Text);
}
private void RightMouseClick(string txtResult)
{
int rowindex = dgvResults.CurrentCell.RowIndex;
int columnindex = dgvResults.CurrentCell.ColumnIndex;
if (string.IsNullOrEmpty(txtResult))
{
txtResult = dgvResults.Rows[rowindex].Cells[columnindex].Value.ToString();
}
else
{
string selectedCell;
double resultText;
selectedCell = dgvResults.Rows[rowindex].Cells[columnindex].Value.ToString();
resultaat = Convert.ToDouble(txtResult) + Convert.ToDouble(selectedCell);
txtResult = Convert.ToString(resultText);
}
}
Fix
private string RightMouseClick(TextBox txtResult)
{
int rowindex = dgvResults.CurrentCell.RowIndex;
int columnindex = dgvResults.CurrentCell.ColumnIndex;
if (string.IsNullOrEmpty(txtResult.Text))
{
return txtResult.Text = dgvResults.Rows[rowindex].Cells[columnindex].Value.ToString();
}
else
{
string selectedCell;
double resultaat;
selectedCell = dgvResults.Rows[rowindex].Cells[columnindex].Value.ToString();
resultaat = Convert.ToDouble(txtResult.Text) + Convert.ToDouble(selectedCell);
return txtResult.Text = Convert.ToString(resultaat);
}
}

You can use the textbox as a parameter
private void RightMouseClick(TextBox txtBox)
{
int rowindex = dgvResults.CurrentCell.RowIndex;
int columnindex = dgvResults.CurrentCell.ColumnIndex;
if (string.IsNullOrEmpty(txtResult))
{
txtBox.Text = dgvResults.Rows[rowindex].Cells[columnindex].Value.ToString();
}
else
{
string selectedCell;
double resultText;
selectedCell = dgvResults.Rows[rowindex].Cells[columnindex].Value.ToString();
resultaat = Convert.ToDouble(txtBox.Text) + Convert.ToDouble(selectedCell);
txtBox.Text = Convert.ToString(resultText);
}
}
You should ensure that you also checking to make sure that the textbox isn't NULL

Move data from one form textbox to another in c#

So I have an invoice total form that should calculate the percentage discount among other things. I'm adding a second form to the code that allows you to change the sales tax I got it to populate the form and actually work with no errors but I can't get it to move the data from the textbox on frmSalesTax to the txtSalesTax.Text in frmInvoiceTotal.
frmInvoiceTotal Code:
public frmInvoiceTotal()
{
InitializeComponent();
}
frmSalesTax percent = new frmSalesTax();
private void btnCalculate_Click(object sender, EventArgs e)
{
decimal productTotal = Convert.ToDecimal(txtProductTotal.Text);
decimal salesTax = (7.75m/100m) * productTotal;
decimal discountPercent = .0m;
if (productTotal < 100)
discountPercent = .0m;
else if (productTotal >= 100 && productTotal < 250)
discountPercent = .1m;
else if (productTotal >= 250)
discountPercent = .25m;
decimal discountAmount = (productTotal + salesTax) * discountPercent;
decimal subtotal = productTotal - discountAmount;
decimal invoiceTotal = (subtotal + salesTax) - discountAmount;
txtSubtotal.Text = subtotal.ToString("c");
txtSalesTax.Text = salesTax.ToString("c");
txtDiscountPercent.Text = discountPercent.ToString("p1");
txtDiscountAmount.Text = discountAmount.ToString("c");
txtTotal.Text = invoiceTotal.ToString("c");
txtProductTotal.Focus();
}
private void btnChange_Click(object sender, EventArgs e)
{
percent.salesTax = txtSalesTax.Text;
switch (percent.ShowDialog())
{
case DialogResult.OK:
txtSalesTax.Text = percent.salesTax;
break;
}
}
private void btnExit_Click(object sender, EventArgs e)
{
this.Close();
}
invoiceTotal GUI:
frmSalesTax Code:
public partial class frmSalesTax : Form
{
public string salesTax
{
get;
set;
}
public frmSalesTax()
{
InitializeComponent();
}
private void btnCancel_Click(object sender, EventArgs e)
{
this.Close();
}
private void btnOk_Click(object sender, EventArgs e)
{
this.salesTax = txtPercent.Text;
txtPercent.Text = "";
Hide();
}
I know I'm missing something but I can't figure out what it is.
salesTax GUI:

You've got the right idea making a property on frmSalesTax to communicate...but you're not really using it.
In your frmInvoiceTotal, you need to send the current value to frmSalesTax.salesTax and then handle the results of the percent dialog returning DialogResult.OK:
private void btnChange_Click(object sender, EventArgs e)
{
percent.salesTax = txtSalesTax.Text; //--> send current value to frmSalesTax
switch ( percent.ShowDialog() ) //--> ShowDialog will return the DialogResult of the pressed button
{
case DialogResult.OK:
txtSalesTax.Text = percent.salesTax; //--> update with new value from frmSalesTax
break;
}
}
...and, in your frmSalesTax, you need to put the txtPercent.Text into the salesTax property when the user clicks the OK button:
private void btnOk_Click(object sender, EventArgs e)
{
this.salesTax = txtPercent.Text; //--> frmInvoiceTotal will read this after the OK button is clicked
txtPercent.Text = "";
Hide();
}
Important: you have to make sure the frmSalesTax buttons have their DialogResult set, so that frmInvoiceTotal.btnOk_Click knows that it's okay to get the value:
Edit
The property (in frmSalesTax) needs to not be based on the form's text values...because you're setting that to "" when the form hides. This is what you want for the property:
public string salesTax
{
get;
set;
}
This would go with the other changes I mentioned earlier.
Edit 2
It's easy to get frustrated. There are a lot of moving pieces, and I can understand how the eyes can cross. Here's the crux of the issue - your calculation is trashing things on you;-)
These lines in the btnCalculate_Click:
decimal salesTax = (7.75m/100m) * productTotal;
decimal discountPercent = .0m;
//...
txtSalesTax.Text = salesTax.ToString("c");
txtDiscountPercent.Text = discountPercent.ToString("p1");
...should be the initial values and come in the form's initialization code:
public frmInvoiceTotal()
{
InitializeComponent();
decimal salesTax = (7.75m/100m) * productTotal;
decimal discountPercent = .0m;
txtSalesTax.Text = salesTax.ToString("c"); //--> the initial value
txtDiscountPercent.Text = discountPercent.ToString("p1");
}
...and then, the calculation should not re-populate txtSalesTax.Text or txtDiscountPercent.Text. The txtSalesTax.Text might be update from showing frmSalesTax, and I'm guessing you're gonna make another form to override discount percent at some point.
private void btnCalculate_Click(object sender, EventArgs e)
{
decimal productTotal = Convert.ToDecimal(txtProductTotal.Text);
decimal salesTax = Convert.ToDecimal(salesTax.Text) * productTotal; //--> if it got changed in frmSalesTax
decimal discountPercent = .0m;
if (productTotal < 100)
discountPercent = .0m;
else if (productTotal >= 100 && productTotal < 250)
discountPercent = .1m;
else if (productTotal >= 250)
discountPercent = .25m;
decimal discountAmount = (productTotal + salesTax) * discountPercent;
decimal subtotal = productTotal - discountAmount;
decimal invoiceTotal = (subtotal + salesTax) - discountAmount;
txtSubtotal.Text = subtotal.ToString("c");
//txtSalesTax.Text = salesTax.ToString("c"); //--> don't do this...it steps on what came from frmSalesTax
//txtDiscountPercent.Text = discountPercent.ToString("p1"); //--> when you add another form to override this
txtDiscountAmount.Text = discountAmount.ToString("c");
txtTotal.Text = invoiceTotal.ToString("c");
txtProductTotal.Focus();
}
I bet this get you a lot closer :-)

How to convert this to a string? [closed]

Closed. This question needs details or clarity. It is not currently accepting answers.
Want to improve this question? Add details and clarify the problem by editing this post.
Closed 5 years ago.
Improve this question
I am trying to make a simple visual calculator and if you press 1 on it it currently just adds the number to it that would mean that 1+1 is 2. I want it to be 11. How do I do this? How will my code look after I did it?
{
double value1 = 0;
double value2 = 0;
double finalResult = 0;
double output = 0;
bool second = false;
bool plus = false;
bool minus = false;
public MainWindow()
{
InitializeComponent();
}
private void button1_Click(object sender, RoutedEventArgs e)
{
if (second == false)
{
value1 = value1 + 1;
output = value1 * 10 + 1;
textresult.Text = output.ToString();
}
else if (second == true)
{
value2 = value2 + 1;
output = value2;
textresult.Text = output.ToString();
}
}
private void button2_Click(object sender, RoutedEventArgs e)
{
if (second == false)
{
value1 = value1 + 2;
output = value1;
textresult.Text = output.ToString();
}
else if (second == true)
{
value2 = value2 + 2;
output = value2;
textresult.Text = output.ToString();
}
}
private void button3_Click(object sender, RoutedEventArgs e)
{
if (second == false)
{
value1 = value1 + 3;
output = value1;
textresult.Text = output.ToString();
}
else if (second == true)
{
value2 = value2 + 3;
output = value2;
textresult.Text = output.ToString();
}
}
private void button4_Click(object sender, RoutedEventArgs e)
{
if (second == false)
{
value1 = value1 + 4;
output = value1;
textresult.Text = output.ToString();
}
else if (second == true)
{
value2 = value2 + 4;
output = value2;
textresult.Text = output.ToString();
}
}
private void button5_Click(object sender, RoutedEventArgs e)
{
if (second == false)
{
value1 = value1 + 5;
output = value1;
textresult.Text = output.ToString();
}
else if (second == true)
{
value2 = value2 + 5;
output = value2;
textresult.Text = output.ToString();
}
}
private void button6_Click(object sender, RoutedEventArgs e)
{
if (second == false)
{
value1 = value1 + 6;
output = value1;
textresult.Text = output.ToString();
}
else if (second == true)
{
value2 = value2 + 6;
output = value2;
textresult.Text = output.ToString();
}
}
private void button7_Click(object sender, RoutedEventArgs e)
{
if (second == false)
{
value1 = value1 + 7;
output = value1;
textresult.Text = output.ToString();
}
else if (second == true)
{
value2 = value2 + 7;
output = value2;
textresult.Text = output.ToString();
}
}
private void button8_Click(object sender, RoutedEventArgs e)
{
if (second == false)
{
value1 = value1 + 8;
output = value1;
textresult.Text = output.ToString();
}
else if (second == true)
{
value2 = value2 + 8;
output = value2;
textresult.Text = output.ToString();
}
}
private void button9_Click(object sender, RoutedEventArgs e)
{
if (second == false)
{
value1 = value1 + 9;
output = value1;
textresult.Text = output.ToString();
}
else if (second == true)
{
value2 = value2 + 9;
output = value2;
textresult.Text = output.ToString();
}
}
private void buttonClear_Click(object sender, RoutedEventArgs e)
{
//remember to add all the other values :)
value1 = 0;
value2 = 0;
finalResult = 0;
output = 0;
second = false;
plus = false;
minus = false;
textresult.Text = output.ToString();
}
private void buttonPlus_Click(object sender, RoutedEventArgs e)
{
output = 0;
textresult.Text = output.ToString();
second = true;
plus = true;
}
private void buttonMinus_Click(object sender, RoutedEventArgs e)
{
output = 0;
textresult.Text = output.ToString();
second = true;
minus = true;
}
private void buttonIs_Click(object sender, RoutedEventArgs e)
{
if (plus == true)
{
finalResult = value1 + value2;
output = finalResult;
textresult.Text = output.ToString();
}
else if (minus == true)
{
finalResult = value1 - value2;
output = finalResult;
textresult.Text = output.ToString();
}
}
}

You can convert int - string with this.
int i = 1;
string s = Convert.ToString(i);

Just wanted to share a some ideas/recommendations to simplify your code
enum Operators
{
NewOperation = -1,
NotSet = 0,
Plus = 1,
Minus = 2
//...
};
int value1, value2;
const string RESET_VALUE = "0";
Operators operation;
public MainWindow() { InitializeComponent(); }
private void MainWindow_Load(object sender, EventArgs e) { textresult.Text = RESET_VALUE; }
private void button1_Click(object sender, EventArgs e) { AppendNumber(1); }
private void button2_Click(object sender, EventArgs e) { AppendNumber(2); }
private void button3_Click(object sender, EventArgs e) { AppendNumber(3); }
private void button4_Click(object sender, EventArgs e) { AppendNumber(4); }
private void button5_Click(object sender, EventArgs e) { AppendNumber(5); }
private void button6_Click(object sender, EventArgs e) { AppendNumber(6); }
private void button7_Click(object sender, EventArgs e) { AppendNumber(7); }
private void button8_Click(object sender, EventArgs e) { AppendNumber(8); }
private void button9_Click(object sender, EventArgs e) { AppendNumber(9); }
private void button0_Click(object sender, EventArgs e) { AppendNumber(0); }
private void AppendNumber(int selected_number)
{
if (operation == Operators.NewOperation)
{
operation = Operators.NotSet;
textresult.Text = $"{selected_number}";
}
else if (textresult.Text.StartsWith("0"))
{
textresult.Text = $"{selected_number}";
}
else
{
textresult.Text = $"{textresult.Text}{selected_number}";
}
if (operation == Operators.NotSet)
value1 = int.Parse(textresult.Text);
else
value2 = int.Parse(textresult.Text);
}
private void buttonPlus_Click(object sender, EventArgs e)
{
operation = Operators.Plus;
textresult.Text = RESET_VALUE;
}
private void buttonMinus_Click(object sender, EventArgs e)
{
operation = Operators.Minus;
textresult.Text = RESET_VALUE;
}
private void buttonIs_Click(object sender, EventArgs e)
{
switch (operation)
{
case Operators.Minus: textresult.Text = $"{(value1 - value2)}"; break;
case Operators.Plus: textresult.Text = $"{(value1 + value2)}"; break;
}
operation = Operators.NewOperation;
value1 = int.Parse(textresult.Text); //save result for next operation
value2 = 0;
}
private void buttonClear_Click(object sender, EventArgs e)
{
operation = Operators.NotSet;
textresult.Text = RESET_VALUE;
value1 = value2 = 0;
}

Choose 2 radio buttons on form

I'm creating a program that allows the user to choose 2 different options, 1 for the dormitories and 1 for the meal plan. I'm using radio buttons for both, but I can only choose 1 button at a time, and I want to be able to choose both at the same time
private void button2_Click(object sender, EventArgs e)
{
this.Close();
}
private void button1_Click(object sender, EventArgs e)
{
int totalCharge = 0;
totalCharge = Dorm() + MealPlan();
Form1 TChargeForm = new Form1();
TChargeForm.label1.Text = totalCharge.ToString("c");
TChargeForm.ShowDialog();
}
private void button3_Click(object sender, EventArgs e)
{
radioButton1.Checked = false;
radioButton2.Checked = false;
radioButton3.Checked = false;
radioButton4.Checked = false;
radioButton5.Checked = false;
radioButton6.Checked = false;
radioButton7.Checked = false;
}
private int Dorm()
{
int total = 0;
if (radioButton1.Checked)
{
total += 1500;
return total;
}
if (radioButton2.Checked)
{
total += 1600;
return total;
}
if (radioButton3.Checked)
{
total += 1500;
return total;
}
if (radioButton4.Checked)
{
total += 1500;
return total;
}
else
{
return total;
}
}
private int MealPlan()
{
int total = 0;
if (radioButton5.Checked)
{
total += 600;
return total;
}
if (radioButton6.Checked)
{
total += 1200;
return total;
}
if (radioButton7.Checked)
{
total += 1700;
return total;
}
else
{
return total;
}
}
}

Try using the GroupName property for each type of button: dorimitories, mealplan

Groupname attribute allows you to create logical groups of selections for radio buttons.
Add this attribute to every radio button or at the group box level.

C# Combobox and numericupdown calculation

private void submitbutton_Click(object sender, EventArgs e)
{
if (fishingrodcomboBox.SelectedIndex == 2)
{
fishingrodcomboBox.SelectedIndex = 2;
decimal two = 18m;
decimal price = two * fishingrodnumericUpDown.Value;
totalfishingrodtextBox.Text = price.ToString("C");
}
else
{
//Do something
}
}
Textbox doesnt display the amount and how i do code it such that when i select something from the combo box i can each a different value?