We Keep Coding

C# Simulation Closing

I just finished my little 2 Person game, but as soon as i finish to enter the 2 colours it just closes on the next Key pressed. I don't find an error, maybe someone can help me? Or also just tell me how to improve my code. I only recently started programming with C# and am thankful for help
My Programm Code is this:
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
namespace Fahrrad
{
internal class Program
{
static void Main(string[] args)
{
Console.WriteLine("Geben sie die Farbe 'blau' oder 'gruen' ein: ");
Velo Velo1 = new Velo(Console.ReadLine());
Console.WriteLine("Geben sie die andere Farbe ein: ");
Velo Velo2 = new Velo(Console.ReadLine());
ConsoleKeyInfo input;
input = Console.ReadKey();
switch(input.Key)
{
case ConsoleKey.UpArrow:
Velo2.Gangwechsel(1);
break;
case ConsoleKey.DownArrow:
Velo2.Gangwechsel(0);
break;
case ConsoleKey.LeftArrow:
Velo2.Bremse(true);
break;
case ConsoleKey.RightArrow:
Velo2.Fortbewegung(true);
break;
case ConsoleKey.W:
Velo1.Gangwechsel(1);
break;
case ConsoleKey.S:
Velo1.Gangwechsel(0);
break;
case ConsoleKey.A:
Velo1.Bremse(true);
break;
case ConsoleKey.D:
Velo1.Fortbewegung(true);
break;
}
}
}
}
And my Class Code is this:
using System;
using System.Collections.Generic;
using System.Linq;
using System.Runtime.CompilerServices;
using System.Text;
using System.Threading.Tasks;
namespace Fahrrad
{
internal class Velo
{
private double gaenge;
private bool bremse;
private string farbe;
private double maxGang;
private bool fahrend;
// Konstruktor
public Velo(string farbe)
{
this.gaenge = 1;
this.farbe = farbe;
if(farbe == "blau")
{
maxGang = 7;
}
else if (farbe == "gruen")
{
maxGang = 3;
}
else
{
Console.WriteLine("Falsche eingabe");
Console.ReadKey();
System.Environment.Exit(1);
}
}
public void Gangwechsel(double schalten)
{
if(schalten == 0)
{
this.gaenge--;
if(this.gaenge == 0 && this.fahrend == true)
{
this.gaenge = 1;
Console.WriteLine("Sie sind bereits im tiefsten gang");
}
}
else if(schalten == 1 && this.fahrend == true)
{
this.gaenge++;
if(this.gaenge > this.maxGang)
{
this.gaenge = this.maxGang;
Console.WriteLine("Sie sind bereits im höchsten Gang");
}
}
else
{
Console.WriteLine("Sie müssen zum Gang wechseln fahren");
}
Console.WriteLine("Sie sind momentan im " + this.gaenge + " gang");
}
public void Bremse(bool bremse)
{
this.bremse = bremse;
if(fahrend == true && this.bremse == true)
{
fahrend= false;
Console.WriteLine("Sie haben die Fahrt beendet");
}
}
public void Fortbewegung(bool fahrend)
{
this.fahrend = fahrend;
if(this.bremse == true && this.fahrend == true)
{
Console.WriteLine("Sie haben die Bremse noch angezogen");
this.fahrend = false;
}
else
{
this.fahrend = true;
Console.WriteLine("Das " + this.farbe + "Fahrrad ist im" + this.gaenge + " Gang losgefahren");
}
}
}
}

You need a game loop that can be terminated by a key.
For example:
static void Main(string[] args)
{
Console.WriteLine("Geben sie die Farbe 'blau' oder 'gruen' ein: ");
Velo Velo1 = new Velo(Console.ReadLine());
Console.WriteLine("Geben sie die andere Farbe ein: ");
Velo Velo2 = new Velo(Console.ReadLine());
ConsoleKeyInfo input;
bool gameIsRunning = true;
while(gameIsRunning)
{
input = Console.ReadKey();
switch(input.Key)
{
// your other rules here
case ConsoleKey.Q:
gameIsRunning = false;
break;
}
}
}

Esc input cuts of Writeline

So I tried to code an userinput with ConsoleKeyInfo. Its works. Than I tried to implement an cancellation when Esc is pressed. It works aswell but it cuts off some of my Writeline. When I try the same code with checking for example M it works just fine!
Is someone able to help?
My Code:
class Program
{
static void Main()
{
while (true)
{
string eingabeArtikelnummer, eingabePlatzalter;
Console.Clear();
Console.Write("Ein neuer Artikel wird angelegt:\n\nGeben Sie die Artikelnummer an: ");
eingabePlatzalter = SteuerungUndEingabe();
if (eingabePlatzalter == ConsoleKey.Escape.ToString()) { break; }
else { eingabeArtikelnummer = eingabePlatzalter; }
}
WartenAufUser();
}
static string SteuerungUndEingabe()
{
ConsoleKey input;
string userEingabe = null;
do
{
input = Console.ReadKey().Key;
if (input == ConsoleKey.Escape)
{
userEingabe = input.ToString();
break;
}
userEingabe += input.ToString();
} while (input != ConsoleKey.Enter);
return (userEingabe);
}
static void WartenAufUser()
{
Console.WriteLine("----------------------------------------------------------------------------------------\n\nBeliebige Taste druecken um ins Menue zu gelangen!");
while (Console.ReadKey() == null) { };
}
}
}
This is the output in the Console:
This is how it should be:
Edit:
So I asked my Teacher how to fix this Problem. He had no idea why it occurs but he recommanded me to go around the Problem and change my Writeline to
Console.WriteLine("x\n----------------------------------------------------------------------------------------\n\nBeliebige Taste druecken um ins Menue zu gelangen!");
The "x\n" miraculously avoids the problem :D

C# Switch Case with if statements not returning me the console.WriteLines

I am trying to create a simple switch case with If-Statements code.
Problem:
I don't get any value back.
For Example:
If I put int Temperature = 0; the Code should output "Es ist kalt". But my console doesn't display anything.
using System;
namespace SwitchCase
{
class Program
{
static void Main(string[] args)
{
int Temperatur = 25;
switch (Temperatur)
{
case 1:
if (Temperatur <= 0)
{
Console.WriteLine("Es ist kalt");
}
break;
case 2:
if (Temperatur >= 25)
{
Console.WriteLine("Es ist überdurchschnittlich warm");
}
break;
case 3:
if (Temperatur <= 13)
{
Console.WriteLine("Es ist mild");
}
break;
};
}
}
}

Your code doesn't make much sense. When Temperatur is exactly 1 or 2, it cannot be less than or equal 0 nor greater than or equal 25. So there's no way Temperatur has a value that gets any of the first two branches of the switch selected and additionally satisfies the if in that branch.
Just using if and else if does what you presumably want:
...
if (Temperatur <= 0)
{
Console.WriteLine("Es ist kalt");
}
else if (Temperatur <= 13)
{
Console.WriteLine("Es ist mild");
}
else if (Temperatur >= 25)
{
Console.WriteLine("Es ist überdurchschnittlich warm");
}
...

your if block never reaches a situation where temperature is 0.
you only have cases for temperatures 1, 2 and 3 (case 1:), so if temperature is anything else than those, nothing will happen.
Therefore, you should use if/else statements:
if (Temperatur <= 0)
{
Console.WriteLine("Es ist kalt");
}
else if (Temperatur <= 13)
{
Console.WriteLine("Es ist mild");
}
else
{
Console.WriteLine("Es ist überdurchschnittlich warm");
}

You Just need if-statement:
using System;
public class Example
{
public static void Main()
{
if (Temperatur <= 0)
{
Console.WriteLine("Es ist kalt");
}
else if (Temperatur <= 13)
{
Console.WriteLine("Es ist mild");
}
else if (Temperatur >= 25)
{
Console.WriteLine("Es ist überdurchschnittlich warm");
}
}
}

Restart the while loop after the error message in the output

Problem: How can I restart the following codeblock? My idea is if you enter a character that will return an error message. What is the condition for the loop?
string r_operation;
Console.Write("\tBitte geben Sie ihre Rechenoperation ein: ");
r_operation = Console.ReadLine();
-------------
while (?r_operation = Console.ReadLine())
{
Console.WriteLine("\tUngültige Eingabe. Bitte geben Sie nur Zahlen ein!");
}

You can convert your existing code to use the int.TryParse method, which returns a bool indicating if the input string is a valid number (and sets an out parameter to the converted value):
Console.Write("\tBitte geben Sie ihre Rechenoperation ein: ");
string r_operation = Console.ReadLine();
int result = 0;
while (!int.TryParse(r_operation, out result))
{
Console.WriteLine("\tUngültige Eingabe. Bitte geben Sie nur Zahlen ein!");
Console.Write("\tBitte geben Sie ihre Rechenoperation ein: ");
r_operation = Console.ReadLine();
}
// When we exit the while loop, we know that 'r_operation' is a number,
// and it's value is stored as an integer in 'result'
Another way to do this is to encapsulate the process of getting a strongly-typed number from the user into a method. Here's one I use:
private static int GetIntFromUser(string prompt, Func<int, bool> validator = null)
{
int result;
var cursorTop = Console.CursorTop;
do
{
ClearSpecificLineAndWrite(cursorTop, prompt);
} while (!int.TryParse(Console.ReadLine(), out result) ||
!(validator?.Invoke(result) ?? true));
return result;
}
private static void ClearSpecificLineAndWrite(int cursorTop, string message)
{
Console.SetCursorPosition(0, cursorTop);
Console.Write(new string(' ', Console.WindowWidth));
Console.SetCursorPosition(0, cursorTop);
Console.Write(message);
}
With these helper methods, your code can be reduced to:
int operation = GetIntFromUser("\tBitte geben Sie ihre Rechenoperation ein: ");
And if you wanted to add some additional constraints, the helper method also takes in a validator function (which takes an int and returns a bool indicating whether or not the int is valid). So if you wanted to restrict the numbers to be from 1 to 5, you could do something like:
var result = GetIntFromUser("Enter a number from 1 to 5: ", i => i > 0 && i < 6);

C# if statement comparing Numbers

I'm really new to programming and have to write a little programming which tests if a number is smaller or bigger than 500, 2000 and 5000. Now I wrote this but it always takes the first else statement even if the number is bigger than 5000 it says the number is smaller than 500. Anybody knows why? Appreciate every help I get. :)
Here's the code:
double rebe, fuenfh = 500.00, zweit = 2000.00, fuenft = 5000.00;
//zweiPro = 2.00, fuenfPro = 5.00, zehnPro = 10.00;
Console.WriteLine("How big is the number? Wie groß war Ihr Rechnungsbetrag? ");
rebe = Console.Read();
if (rebe >= fuenfh)
{
if (rebe >= zweit)
{
if (rebe >= fuenft)
{
Console.WriteLine("bigger or same as 5000");
Console.ReadLine();
Console.Read();
}
else
{
Console.WriteLine("bigger or same as 2000 but smaller than 5000 // Groesser gleich als 2000 aber kleiner als 5000");
Console.ReadLine();
Console.Read();
}
}
else
{
Console.WriteLine("bigger or same as 500 but smaller than 2000 // Groesser gleich 500 aber kleiner als 2000");
Console.ReadLine();
Console.Read();
}
}
else
{
Console.WriteLine("smaller than 500 // Leider gibt es keinen Rabatt. :(");
Console.ReadLine();
Console.Read();
}

change your input from rebe = Console.Read(); to rebe = Convert.ToDouble( Console.ReadLine());. I don't think you're pulling in the value that you expected.

This is how it could work, converting the input to double (as hinted by mnield) but also making the code more readible in general. Note how much shorter the code gets when you invert your conditionals.
Console.WriteLine("How big is the number?");
double amount = Convert.ToDouble(Console.Readline());
if (amount < 500.0)
{
Console.WriteLine("smaller than 500");
}
else if (amount < 2000.0)
{
Console.WriteLine("bigger or same as 500 but smaller than 2000");
}
else if (amount < 5000.0)
{
Console.WriteLine("bigger or same as 2000 but smaller than 5000");
}
else
{
Console.WriteLine("bigger or same as 5000");
}
Console.ReadLine();

double fuenfh = 500.00, zweit = 2000.00, fuenft = 5000.00;
//zweiPro = 2.00, fuenfPro = 5.00, zehnPro = 10.00;
do
{
Console.WriteLine("\nWie groß war Ihr Rechnungsbetrag? ");
var eingabe = double.TryParse(Console.ReadLine(), out var rebe);
if (eingabe)
{
if (rebe >= fuenft) { Console.Write($"Die eingabe ist größer oder gleich {fuenft}"); }
else if (rebe >= zweit) { Console.Write($"Die eingabe ist größer oder gleich {zweit} aber kleiner als {fuenfh}"); }
else if (rebe >= fuenfh) { Console.Write($"Die eingabe ist größer oder gleich {fuenfh} aber kleiner als {zweit}"); }
else { Console.Write($"Die eingabe ist kleiner als {fuenfh}"); }
}
else { Console.WriteLine("Bitte Zahl eingeben!"); }
} while (true);
This way you'll have whole funktion in the loop!
double.TryParse - converts your input to the double type
if (eingabe) - if numbers are entered it sends you in the if blocks with your variables
do {} while (true) - endless loop to test your function without clicking debug all the time