We Keep Coding

I want the corresponding ID of last record in MS Access to appear inside a Message Box [duplicate]

This question already has answers here:
how to get the last record number after inserting record to database in access
(6 answers)
Closed 1 year ago.
Am working with Access as Database in C# (Visual Studio 15). I want to save form entries (add record) into the Access Database and would want the corresponding ID of the record to show in MsgBox upon a successful saving. I have tried the following:
private void Form21_Load(object sender, EventArgs e)
{
try
{
connection.Open();
checkConnection.Text = "Server Connection, Successful";
connection.Close();
}
catch (Exception ex)
{
MessageBox.Show("Error, Server not connected " + ex);
}
}
private void Button6_Click(object sender, EventArgs e)
{
connection.Open();
OleDbCommand command = new OleDbCommand();
command.Connection = connection;
command.CommandText = "insert into Students_File ([YourNames],[Nationality],[StateOfOrigin],[PlaceOfBirth],[DoB],[HomeAddress],[LastSchools1],[LastClass1],[LastSchools2],[LastClass2],[LastSchools3],[LastClass3],[AdmClass],[CurrentClass],[Guidian],[GuardianContact],[UserName],[PassWord],[Gender],[RegistrationDate]) values('" + YourNames.Text + "','" + Nationality.Text + "','" + StateOfOrigin.Text + "','" + PlaceOfBirth.Text + "','" + DoB.Text + "','" + HomeAddress.Text + "','" + LastSchools1.Text + "','" + LastClass1.Text + "','" + LastSchools2.Text + "','" + LastClass2.Text + "','" + LastSchools3.Text + "','" + LastClass3.Text + "','" + AdmClass.Text + "','" + CurrentClass.Text + "','" + Guidian.Text + "','" + GuardianContact.Text + "','" + UserName.Text + "','" + PassWord.Text + "','" + Gender.Text + "','" + RegistrationDate.Text + "')";
command.ExecuteNonQuery();
//MessageBox.Show("Congrats! Your registration, is successful. You may now click close button, then proceed to login");
command.CommandText = "Select * from Students_File where UserName='" + UserName.Text + "' and PassWord='" + PassWord.Text + "'";
OleDbDataReader reader = command.ExecuteReader();
int count = 0;
while (reader.Read())
{
count = count + 1;
}
if (count == 1)
{
MessageBox.Show("Congrats! Your registration, is successful. You may now click close button, then proceed to login");
this.Close();
}
else if (count > 1)
{
MessageBox.Show("Sorry, the chosen username or password is currently existing or picked by another user. Consequently, your registration was not successful. Do please, decide another but a unique one. Thank you");
}
connection.Close();
}

You can do it this way:
using (OleDbCommand Command = new OleDbCommand("", conn))
{
Command.CommandText = "Your big ugly mess - need to change this to parmaters!)";
Command.Connection.Open();
Command.ExecuteNonQuery();
Command.CommandText = "Select ##Identity";
var intLastID = Command.ExecuteScalar;
MsgBox("Last id into database = " + intLastID);
}
As noted, you do want to change that insert command - it too long, too difficult to maintain, and subject to mistakes in code and even sql injection.
But, for now, you can use the above approach to get/pick up the last ID insert.

In solution to my inquiry, i have the following code (From Kevin):
string query = "Insert Into Categories (CategoryName) Values (?)";
string query2 = "Select ##Identity";
int ID;
string connect = "Provider=Microsoft.Jet.OLEDB.4.0;Data Source=|DataDirectory|Northwind.mdb";
using (OleDbConnection conn = new OleDbConnection(connect))
{
using (OleDbCommand cmd = new OleDbCommand(query, conn))
{
cmd.Parameters.AddWithValue("#CategoryName", OleDbType.Integer);
conn.Open();
cmd.ExecuteNonQuery();
cmd.CommandText = query2;
ID = (int)cmd.ExecuteScalar();
}
}
Now, my challenge is how do i get the ID to appear in messagebox after a successful record creation. Please consider my earliest code in this post in connection with this.

SQL Server store 0 values in Int column or empty value in String and also Date store like 2001-01-01

Here is my aspx.cs Code behind Class I am Setting properties and set correctly
Here is my getter/setter properties I get properties in SQL insert see below query
Here is my VoucherSubmit method that post the form into SQL Server 2012 database:
public class InsertData
{
public void VoucherSubmit()
{
myconection mycon = new myconection();
VoucherForm vr = new VoucherForm();
string Query1 = "insert into Voucher(VrType,VrDate,CreatedBy,CreationDate,SubmittedBy,SubmittedDate,ApprovedBy,ApprovedDate,Method,BillNo,ChequeNo,DemandNo,Branch,AccountDebit,AccountCredit,Debit,Credit,Description)values('" + vr.getvouchertype() + "','" + vr._date + "','" + vr._createdby + "','" + vr.getvoucher_creationdate() + "','" + vr._submittedby + "','" + vr._submitteddate + "','" + vr._approvedby + "','" + vr._approveddate + "','" + vr._method + "','" + vr._billno + "','" + vr._chequeno + "','" + vr._demandno + "','" + vr._branch + "','" + vr._accountdebit + "','" + vr._accountcredit + "','" + vr._debit + "','" + vr._credit + "','" + vr._description + "')";
SqlCommand cmd = new SqlCommand(Query1, mycon.GetConnection());
cmd.ExecuteNonQuery();
mycon.GetConnection().Close();
}
}

You are not passing initialized VoucherForm, but creating new one in your VoucherSubmit method.
public void btn_save_Click(object sender, EventArgs e)
{
// All the stuff you have there just change single line
insert.VoucherSubmit(vf);
}
public void VoucherSubmit(VoucherForm vf)
{
myconection mycon = new myconection();
// remove VoucherForm vf = new VoucherForm();
string Query1 = "insert into Voucher(VrType,VrDate,CreatedBy,CreationDate,SubmittedBy,SubmittedDate,ApprovedBy,ApprovedDate,Method,BillNo,ChequeNo,DemandNo,Branch,AccountDebit,AccountCredit,Debit,Credit,Description)values(#VrType,#VrDate,#CreatedBy,#CreationDate,#SubmittedBy,#SubmittedDate,#ApprovedBy,#ApprovedDate,#Method,#BillNo,#ChequeNo,#DemandNo,#Branch,#AccountDebit,#AccountCredit,#Debit,#Credit,#Description)";
SqlCommand cmd = new SqlCommand(Query1, mycon.GetConnection());
cmd.InsertCommand.Parameters.Add("#VrTyp").Value = vr.getvouchertype();
cmd.InsertCommand.Parameters.Add("#VrDate").Value = vr._date;
cmd.InsertCommand.Parameters.Add("#CreatedBy").Value = vr._createdby;
cmd.InsertCommand.Parameters.Add("#CreationDate").Value = vr.getvoucher_creationdate();
cmd.InsertCommand.Parameters.Add("#SubmittedBy").Value = vr._submittedby;
cmd.InsertCommand.Parameters.Add("#SubmittedDate").Value = vr._submitteddate;
cmd.InsertCommand.Parameters.Add("#ApprovedBy").Value = vr._approvedby;
cmd.InsertCommand.Parameters.Add("#ApprovedDate").Value = vr._approveddate;
cmd.InsertCommand.Parameters.Add("#Method").Value = vr._method;
cmd.InsertCommand.Parameters.Add("#BillNo").Value = vr._billno;
cmd.InsertCommand.Parameters.Add("#ChequeNo").Value = vr._chequeno;
cmd.InsertCommand.Parameters.Add("#DemandNo").Value = vr._demandno;
cmd.InsertCommand.Parameters.Add("#Branch").Value = vr._branch;
cmd.InsertCommand.Parameters.Add("#AccountDebit").Value = vr._accountdebit;
cmd.InsertCommand.Parameters.Add("#AccountCredit").Value = vr._accountcredit;
cmd.InsertCommand.Parameters.Add("#Debit").Value = vr._debit;
cmd.InsertCommand.Parameters.Add("#Credit").Value = vr._credit;
cmd.InsertCommand.Parameters.Add("#Description").Value = vr._description;
cmd.ExecuteNonQuery();
mycon.GetConnection().Close();
}
UPDATE:
Dan Guzman in the comment suggested to use overload with specified sql data type to avoid performance issues.
the main point of the article I referenced is that the SqlDbType
should be explicitly specified along with the max length in the case
of varchar columns. For example,
cmd.Parameters.Add("#VrDate",
SqlDbType.DateTime).Value = DateTime.ParseExact(vr._date,
"yyyy-MM-dd", null);
This will ensure the desired data types are
passed and avoid excessive cached plans in SQL Server.
Thanks for update!
Related links:
Can we stop using AddWithValue() already?

Get checked Items into MS Access database

I´m using C# Windows forms application and i got 5 items in a checklistbox.
Now I have to save these items into a MS Access database table.
Does anyone knows how i should do it?
(Sprachen = checkedlistbox)
private void button1_Click_1(object sender, EventArgs e)
{
try
{
connection.Open();
OleDbCommand command = new OleDbCommand();
command.Connection = connection;
command.CommandText = "INSERT INTO Employee (Vorname, Nachname, Wohnort, Geburtstag, Abteilung, Nummer, MKZ, Führerschein, Sprachen) values('" + Vorname.Text + "','" + Nachname.Text + "','" + Wohnort.Text + "','" + Geburtstag.Text + "','" + Abteilung.Text + "','" + Mitarbeiter.Text + "','" + MKZ.Text + "'," + Führerschein.Checked.ToString() + "," + Sprachen.SelectedItems + ")";
command.ExecuteNonQuery();
MessageBox.Show("Daten gespeichert!");
connection.Close();
}
catch (Exception ex)
{
MessageBox.Show("Error " + ex);
}
everytime i tried it with toString(), it gives me an error:
For at least one required parameter no value was specified.
I can only count how many items i´ve checked in the checklistbox.
Anyone got an solution?

Sprachen.SelectedItems returns list of selected items. If you are trying to insert the items which are checked in checkedlistbox then you have to loop for checklistbox.CheckedItems.
Instead of "Sprachen.SelectedItems" pass checklistbox.CheckedItems[0].ToString() as value and check the code. Note: 0 is hard coded.. later you can loop it
String type value must be passed within single quote. Check out last two fields.

Insert to database Change the alias to a valid name?

I have a sql table which has an image cloumn I'm trying to insert the image after converting it into byte.... the my insert query looks like this
INSERT INTO Member (F_NAME, L_NAME, D_O_B, UAE_ID_NO, MOBILE_NO, EMAIL_ID, REFERER, REF_CONTACT, ADDRESS, PICTURE) VALUES ('" + fname + "','" + lname + "','" + dob.ToShortDateString() + "','" + uaeid + "','" + mobile + "','" + emailid + "','" + reffere + "','" + refercontact + "','"+address+"',"+photo+")"
here pic is the image column... I'm converting the image into byte array using the following method
MemoryStream ms = new MemoryStream();
//save the image into memory stream
pBoxMember.Image.Save(ms, ImageFormat.Jpeg);
//assign the byte array with total size of memorystream
photo = new byte[ms.Length];
ms.Position = 0;
ms.Read(photo, 0, photo.Length);
return true;
But it is giving me this error
An object or column name is missing or empty. For SELECT INTO statements, verify each column has a name. For other statements, look for empty alias names. Aliases defined as "" or [] are not allowed. Change the alias to a valid name.
invalid syntax near ".

If this should work at all this should look like this:
var sql = "INSERT INTO Member (F_NAME, L_NAME, D_O_B, UAE_ID_NO, MOBILE_NO, " +
"EMAIL_ID, REFERER, REF_CONTACT, ADDRESS, PICTURE) " +
"VALUES ('" + fname + "','" + lname + "','" + dob.ToShortDateString() + "','" + uaeid + "','" + mobile + "','" + emailid + "','" + reffere + "','" + refercontact + "','" + address + "'," + photo + ")"
But you should use SQL Params for this, something like:
string queryString = "INSERT INTO Member (F_NAME, L_NAME, D_O_B, UAE_ID_NO, ... VALUES(#fname ,#lname ....)";
SqlCommand cmd = new SqlCommand(queryString, dbConnection);
cmd.Parameters.AddWithValue("#fname",fname);
cmd.Parameters.AddWithValue("#lname",lname);
...
cmd.Parameters.AddWithValue("#blobParam",YourBytesArray);
...
cmd.ExecuteNonQuery();

OverFlow Exception in OLEDB

I am getting an error while i am trying to insert a user id of my client in the ms access database.
The error i am getting is Overflow.
when i am trying to insert its getting the above error.
I am using these code.
OleDbCommand cmd = new OleDbCommand("insert into UserInfo " + "([firstname], [lastname], [gender], [occupation], [expirydate], [UserId], [phoneno]) " + " values('" + txt_FirstName.Text + "','" + txt_LastName.Text + "','" + cmb_Gender.Text + "','" + cmb_Occupation.Text + "','" + txt_expiryDate.Text + "','" + txt_HardDiskId.Text + "','" + txt_PhoneNo.Text + "');", con);
OleDbCommand cmd1 = new OleDbCommand("select * from UserInfo where (HardDiskId='" + txt_HardDiskId.Text + "')", con);
int temp = 0;
try
{
con.Open();
string count = (string)cmd1.ExecuteScalar();
if ((count == "") || (count == null))
{
temp = cmd.ExecuteNonQuery();
if (temp > 0)
{
MessageBox.Show("User ID of " + txt_FirstName.Text + " " + txt_LastName.Text + " has been added");
}
else
{
MessageBox.Show("Record not added");
}
}
else
{
MessageBox.Show("User ID of " + txt_FirstName.Text + " already exists. Try another user ID.");
}
}

Aside from being open to SQL Injection (which you should parameterize your OleDbCommand), first thought on a problem is what you are trying to store the data. Do any of the text fields have special characters or apostrophe in name which would otherwise pre-terminate your embedded .... '" + nextField + "' ..." entries and throw the balance off.
Another... don't know if the parser is picky or not... but a space after values, before open paren.... " values(" to " values (".
Third, and more probable the issue is the expiration date. If its a date field, and you are trying to put in as text, it might be failing on the data type conversion.