How can I insert an "array" of strings into a value? - c#

I simply want to enter the following numbers
100 8
15 245
1945 54
into a value, but for some reason when I copy-paste it into my ReadLine - program kicks me out (with no error or smth - so I cannot barely understand what's just happened...)
I've already a code that allows me to insert a set of numbers when they are arranged in a LINE (but not as a table as shown in the description...)
int numberOfElements = Convert.ToInt32(Console.ReadLine());
int sum = 0;
string input = Console.ReadLine();
var numbers = Array.ConvertAll(input.Split(' '), int.Parse).ToList();
Console.ReadKey();
I expect to have my numbers in a List

Console.ReadLine() only reads one line. string input = Console.ReadLine() reads first line When you get into new line. In your case only first line is read then for the second line your program only gets first character and exits.
Check This:
int numberOfElements = Convert.ToInt32(Console.ReadLine());
int sum= 0;
for (int i=0; i< numberOfElements; i++)
{
string input = Console.ReadLine();
sum += Array.ConvertAll(input.Split(' '), int.Parse).Sum();
}
Console.WriteLine(sum);
Working Fiddle

Obviously when you paste in Carriage returns, ReadLine only takes up to the first Carriage Return, you will need a loop of some description
int numberOfElements = Convert.ToInt32(Console.ReadLine());
var sb = new StringBuilder();
for (int i = 0; i < numberOfElements; i++)
{
Console.WriteLine($"Enter value {i+1}");
sb.AppendLine(Console.ReadLine());
}
var input = sb.ToString();
// do what ever you want here
Console.ReadKey();

I'm assuming that you're looking for a way to allow a user to paste something from another source into your console program, so you're looking for an answer where you can process a multi-line string input from the user (where they paste a string that contains one or more newline characters).
If this is the case, then one way to do this would be to check the value of Console.KeyAvailable after the first call to ReadLine to see if there's still more input in the buffer, and if there is, add it to the input you've already captured.
For example, here's a method that takes in a prompt (to display to the user), and then returns a List<string> that contains an entry for each row the user pasted (or typed):
private static List<string> GetMultiLineStringFromUser(string prompt)
{
Console.Write(prompt);
// Create a list and add the first line to it
List<string> results = new List<string> { Console.ReadLine() };
// KeyAvailable will return 'true' if there is more input in the buffer
// so we keep adding the lines until there are none left
while(Console.KeyAvailable)
{
results.Add(Console.ReadLine());
}
// Return the list of lines
return results;
}
In use, this might look something like:
private static void Main()
{
var input = GetMultiLineStringFromUser("Paste a multi-line string and press enter: ");
Console.WriteLine("\nYou entered: ");
foreach(var line in input)
{
Console.WriteLine(line);
}
GetKeyFromUser("\nDone!\nPress any key to exit...");
}
Output
What you do next depends on what you want to accomplish. If you want to take all the lines, split them on the space character, and return all the results as a list of individual integers, you could do something like this:
private static void Main()
{
int temp = 0;
List<int> numbers =
GetMultiLineStringFromUser("Paste a multi-line string and press enter: ")
.SelectMany(i => i.Split()) // Get all the individual entries
.Where(i => int.TryParse(i, out temp)) // Where the entry is an int
.Select(i => Convert.ToInt32(i)) // And convert the entry to an int
.ToList();
Console.WriteLine("\nYou entered: ");
foreach (var number in numbers)
{
Console.WriteLine(number);
}
GetKeyFromUser("\nDone!\nPress any key to exit...");
}
Output
Or you could even do something fancy like:
Console.WriteLine($"\n{string.Join(" + ", numbers)} = {numbers.Sum()}");
Output

Related

Getting a system format exception at the int32.parse line

For some reason, I continue to get a system format exception at the int32.parse line. I don’t understand what I’m doing wrong.
My assignment is to:
Create a simple application in which you have variables of appropriate types to
store the user’s name and three test grades.
Ask for this information from the user and store it appropriately.
Create a variable to store the user’s test average.
Calculate and assign
this value using the stored information given to you by the user.
My code follows:
class MainClass
{
public static void Main (string[] args)
{
Console.WriteLine ("Please enter your name: ");
string name;
name = Console.ReadLine ();
Console.WriteLine ("Hello, " + name);
int score;
Console.Write ("What are your last three test scores: ");
score = Int32.Parse(Console.ReadLine ());
Console.WriteLine("Your test scores are" + score + "90,92,95");}
}
It's important to inspect user input in order to avoid Exceptions due to invalid input. Here's how I would do it:
class MainClass
{
public static void Main(string[] args)
{
//Variable Declarations
string response,
name;
string[] scores;
int sumOfAllScores,
scoreCount;
bool validResponse;
System.Text.RegularExpressions.Regex onlyDigits;
//We need to assign response an initial value or else Visual Studio will complain
//since it only receives its real value within a while loop (which as far as the parser is concerned
//may or may not ever iterate.
response = string.Empty;
//Booleans are automatically assigned an intial value of 'false' but I like to intialize them anyway
validResponse = false;
//Initialize the score sum and score counter variables.
sumOfAllScores = 0;
scoreCount = 0;
//This Regex pattern will allow us to inspect a string to ensure that it contains only digits.
onlyDigits = new System.Text.RegularExpressions.Regex(#"^\d+$");
Console.Write("Please enter your name: ");
name = Console.ReadLine();
Console.WriteLine("Hello, " + name);
//This loop will iterate until the user provides valid input (comma-separated integers).
while (!validResponse)
{
//When we enter the while loop, set validResponse to true.
//If we encounter any invalid input from the user we will set this to false so that
//the while loop will iterate again.
validResponse = true;
Console.Write("What are your last three test scores (comma-separated list, please): ");
response = Console.ReadLine();
//Split response into an array of strings on the comma characters
scores = response.Split(',');
//Inspect each element of the string array scores and take action:
foreach (string scoreEntry in scores)
{
//If the current array member being inspected consists of any characters that are not integers,
//Complain to the user and break out of the foreach loop. This will cause the while loop to iterate
//again since validResponse is still false.
if (!onlyDigits.IsMatch(scoreEntry))
{
//Complain
Console.WriteLine("Invalid response. Please enter a comma-separated list of test scores");
Console.WriteLine(Environment.NewLine);
//Re-initialize the score sum and score count variables since we're starting over
sumOfAllScores = 0;
scoreCount = 0;
//Set validResponse to false and break out of the foreach loop
validResponse = false;
break;
}
//Otherwise, we have valid input, so we'll update our integer values
else
{
//Iterate the number of scores that have been entered and validated
scoreCount++;
//Use the static Convert class to convert scoreEntry to an Integer
//and add it to the score sum
sumOfAllScores += Convert.ToInt32(scoreEntry);
}
}
}
//Report the results to the user:
Console.WriteLine("Your test scores are: " + response);
Console.WriteLine("Your average score is " + sumOfAllScores / scoreCount);
}
}
Console.Readline() returns a string. In your case this string might be something like "96,92,99".
string inputs = Console.ReadLine();
First step would be to split the string into three strings like "96", "92", "99" by using the comma as a separator
string[] parts = input.Split(',');
Now each string needs to be converted into an integer, one by one
// Create array of integers with the same size as the array of parts
int[] grades = new int[parts.Length];
// Loop through the input parts and convert them into integers
for(i=0; i<parts.Length; i++)
{
// Use `TryParse()` as it wont throw an Exception if the inputs are invalid
int.TryParse(parts[i], out grades[i]);
}
Now you can do things like calculate an average. I prefer the use the built in functions like .Average() or .Sum()
Console.WriteLine("The average grade is " + grades.Average().ToString("F1"));
You can combine an array of values into a comma separated string using the string.Join() function.
Console.WriteLine("I parsed these values: " + string.Join(",", grades));
So for example if the input is invalid you will see a 0 in place of the invalid value. Here is an example console output.
Enter grades separated by commas:
92,A,96,94
I parsed these values: 92,0,96,94
The average grade is 70.5
To convert the array of strings into an array of integers with one statement, use LINQ.
int[] grades = parts.Select((part) => int.Parse(part)).ToArray();
This will though an exception with invalid inputs. Making the above to work with TryParse() is tricker, but doable.

Inputing a selection from an array c#

Hi there I'm very new to C# so please bear with me if my question has a very obvious answer.
I am trying to write a code that displays an array of options to the user with a number to select the option. The user then selects their option and the code will display their selection from the array.
So for example
Select 1 for apples
Select 2 for oranges
Select 3 for pears
Please Enter your Selection :
I keep typing a for loop to display my area but I cannot get my program to read the input from the array this is what I have so far
static void Main(string[] args) {
string[] fruit = [3]
fruit[0]=("apples");
fruit[1]=("oranges");
fruit[2]=("pears");
for (int i = 0; i < fruit.length; i++)
{
Console.WriteLine("Enter {0} to select {1}", i, fruit[i]);
}
string choice = Console.ReadLine();
int i = int.Parse(choice);
Console.WriteLine("You have selected {0} which is {1}", i, fruit[i]);
Console.ReadLine();
}
This gives me an error and if I place this within the for loop then the program does not display me all my options.
Multiple problems with your code:
Define your string array like string[] fruit = new string[3];
Since you have defined i in your for loop, you need to use a new variable for your input.
Your condition in for loop should be i < fruit.Length
This is more of a suggestion, use int.TryParse to parse input from console, check if the entered number is an int and also check if the number is less than the array length.
You need to give different name to your loop variable or the user choice.
Also you might want to use TryParse intead of Parse to prevent possible FormatExceptions:
int userChoice;
if(int.TryParse(choice, out userChoice) && userChoice < fruit.Length)
Console.WriteLine("You have selected {0} which is {1}", userChoice, fruit[userChoice]);
void Main()
{
// compile a list of possible fruits (remember that c# arrays are
// 0-indexed (first element is actually 0 and not 1))
string[] fruits = new[]{
"apples",
"oranges",
"pears"
};
// iterate over the options and output each one
for (var i = 0; i < fruits.Length; i++){
// add one to index value to make it non-0 based
Console.WriteLine("Enter {0} to select {1}", i + 1, fruits[i]);
}
// continue to read user input until they select a valid choice
Int32 choice = 0;
do
{
// read user input
String input = Console.ReadLine();
// [try to] convert the input to an integer
// if it fails, you'll end up with choice=0
// which will force the while(...) condition to fail
// and, therefore, retry for another selection.
Int32.TryParse(input, out choice);
}
// number should be between 1 and (fruits.Length + 1)
while (choice < 1 || choice > (fruits.Length + 1));
// to reference it, subtract 1 from user's choice to get back to
// 0-indexed array
Console.WriteLine("You have selected {0} which is {1}", choice, fruits[choice - 1]);
}
You have multiple typos and you can't use the variable i twice.
Try this:
static public void Main(string[] args)
{
string[] fruit = new string[3];
fruit[0]=("apples");
fruit[1]=("oranges");
fruit[2]=("pears");
for (int i = 0; i < fruit.Length; i++)
{
Console.WriteLine("Enter {0} to select {1}", i, fruit[i]);
}
string choice = Console.ReadLine();
int j = int.Parse(choice);
Console.WriteLine("You have selected {0} which is {1}", j, fruit[j]);
Console.ReadLine();
}
You might also want to include some error trapping if the user enters something that can't be parsed as an int (you could use TryParse for example).
Typos: Your array declaration was wrong and you need a captial L on length for the array length property.
Your string array declaration is incorrect. Try
string[] fruit = new string[3];
or you can declare and initiate thus:
string[] fruit = new string[3]{"apples", "oranges", "pears"};
or simpler:
string[] fruit = {"apples", "oranges", "pears"};

getting input from a user to fill a list in C#

Ok guys, im just starting C# and trying to transition from the basic side of C++.
I'm working on a lesson(not for a grade, it is a learning assignment), and I have everything set up except for getting the user input. I am trying to use a list instead of an array but I can't figure out how to get it to let the user enter the prices.
This is a project for a simple register. The user has to enter the price. And here will be less than 100 items.
This is what I have so far:
static void Main()
{
double i;
Console.Writeline("Enter Item Prices\n");
List<double> items = new List<double>[i];
Console.ReadLine(items);
Console.WriteLine("{0}: ", i, items[i]);
for (double i = 0; i < 100; i++)
{
items.Add(i);
}
return 0;
}
I have all the calcs set up, just can't get the input needed for the prices. I know some things with i are wrong. Also, its the WriteLine and ReadLine taking the place of cout and cin that is messing me up I think.
I just need to figure out how to get the prices and get them put into my formulas.
I will give the best answer props for helping in my program comments.
Edit:
I need it to go back and check if the user want to continue or not
The order is a bit messed up. Fixed it for you:
Console.Writeline("Enter Item Prices\n");
List<double> items = new List<double>();
for (double i = 0; i < 100; i++)
{
string userInput;
double newItem;
// repeatedly ask for input from the user until it's a valid double
do
{
Console.Write(string.Format("Enter item #{0}: ", i));
// read from console into userInput
userInput = Console.ReadLine();
} while (!double.TryParse(userInput, out newItem))
// add the new item to the array
items.Add(newItem);
}
// output all the items to the console, separated by commas
Console.WriteLine(
string.Join(", ",
items.Select(item => item.ToString())
)
);
Minimal example.
class Program
{
static void Main(string[] args)
{
//reading the input and assign it to s
string s = Console.ReadLine();
//writing the input
Console.WriteLine(s);
}
}
You can add multiple items (from user input) separated by space into a list as follows:
string[] arrItems = Console.ReadLine().Split(' ');
List<double> lstItems = new List<double>(Array.ConvertAll(arrItems, arrTemp =>
Convert.ToDouble(arrTemp)));

Alphabetizing Arrays

So I'm having a couple of troubles with my code. For starters, I have this problem which is outputting all of the arrays. Mind you I have only been coding for 12 days and my teacher has somewhat skipped over the very basics in C# coding due to my college's outlook on learning. AND I just learned that it doesn't order them alphabetically.....
static int inputPartInformation(string[] pl)
{
int i = 0;
do
{
Console.Write("Enter a Name: ");
//for the player
pl[i] = Console.ReadLine();
}
while (pl[i++].CompareTo("Q") != 0);
//if they write Q for the player it will quit
return i - 1;
}
static void Main(string[] args)
{
String[] players = new String[100];
Array.Sort(players);
// Sort array.
//defines players in this new instance
var count = inputPartInformation(players);
//for the portion of the code that handles the input
//calculates the average score
Console.WriteLine("List of People in Order: {0}, {1}, {2}, {3}, {4}, {5}, {6},", players);
Console.ReadLine();
}
}
}
You are sorting before the names are populated; that does nothing.
You are printing a single item using a fixed multi-item list of parameter references {0}, {1},{2} and so on; it is not going to work, and even if it did it would limit your output to the first seven items
You do not know how many items to sort. Change void inputPartInformation(string[] pl) to return count (which is i-1), and use Array.Sort(players, 0, count);
The simplest way to convert multiple strings into a single string is by using string.Join:
Console.WriteLine("List of People in Order: {0}", string.Join(", ", players.Take(count)));
First, "Q" is being added to the input list because you don't test for "Q" until after the input has been accepted and inserted into your array. One way of reworking this would be to hold the input name into a temporary variable, test that for "Q", and add it to your array only if it is something else. Within your loop, modify your input/test to something like:
bool enteringNames=true;
do{
String nextName = Console.ReadLine();
if (nextName.CompareTo("Q")==0)
{
enteringNames=false;
}
else
{
p[i]=nextName;
}
i++;
}
while(enteringNames);
This is just one way of getting the job done. Keep in mind that a fixed 100-entry array isn't the most robust way of doing this...never know how many names might be going in!
Now, the last WriteLine is a bit odd, but I think you can figure that part out on your own - its pretty straightforward to either iterate through the array, or just join all the strings together :)
Second, your sort isn't working because you call Array.Sort(players) before you call inputPartInformation(players) to actually load the data - so you're sorting without any data!. Move the Array.Sort call after the call to inputPartInformation.
Hope this helps!
Try this, it will work, but first try to study about the APIs
static int inputPartInformation(string[] pl)
{
int i = 0;
String temp;
while (true)
{
Console.Write("Enter a Name: ");
temp=Console.ReadLine();
if (temp=="Q")
break;
else pl[i++] = temp;
}
return i;
}
static void Main(string[] args)
{
String[] players = new String[100];
int size=inputPartInformation(players);
for (int i = 0; i <= size; i++)
Console.WriteLine(players[i]);
}
}
Q is appearing in your outcome because you are assigning it to your array.
Rewrite you function to check the value before you assign it, for example
static void inputPartInformation(string[] pl)
{
int i = 0;
do
{
Console.Write("Enter a Name: ");
//for the player
newStrInput = Console.ReadLine();
if (newStrInput == "Q")
break;//if they write Q for the player it will quit
pl[i]=newStrInput;
i++;
}
while (i>-1);//infinite loop
}

Get the sum of an array in C# but receiving int32 error

In general, I know that int32 errors mean that a string value is not getting converted for the console program. I have seen a lot of code trying to find the answer to this including the following stackoverflow questions (seen much more but these were most useful:
How to sum up an array of integers in C#
Error CS1501: I'm not overloading a Sum() method correctly
CS0019 Operator cannot be applied to operands of type 'bool' and 'int'
That being said, this is also a homework assignment, titled UsingSum.cs as seen in a couple of these links. The difference in mine and these is that I am trying to make it so that the user enters however many Integers they want, then they are added up. The entire assignment is written in link 2....
The problem: I keep getting either 0 or System.Int32[] instead of the sum, despite the changes I make.
I cannot use Linq.
Here is the code:
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
namespace UsingSum
{
class Program
{
static void Main(string[] args)
{
int i;
int usrInput;
bool running = true;
//Enter Question Asking Loop w/ running=true
while (running)
{
Console.Write("Enter a number or enter 999 to exit: ");
int[] array1 = new int[0];
for (i = 0; i < array1.Length; i++)
{
usrInput = Convert.ToInt32(Console.ReadLine());
array1[i] = Convert.ToInt32(usrInput);
}
for (i = 0; i < array1.Length; i++)
{
Console.WriteLine(array1[i]);
}
/*If the user enters 999, calls Sum() and asks user to press any key to exit.
changes 'running' from true to false to exit the question loop*/
int exit = Convert.ToInt32 (Console.ReadLine());
if (exit == 999)
{
running = false;
Sum(array1);
}
}
//Loop complete
Console.WriteLine("Press any key to exit.");
Console.ReadLine();
}
public static void Sum(int[] numbers)
{
int [] sum1 = new int [0];
int sum2 = 0;
//Program accepts user responses with or w/o this loop...Int.32 error present both ways
//for (int a = 0; a < numbers.Length; ++a)
//sum1[a] = a;
//additional loop tried w/o the loop above/below;
//when used in the WriteLine w/ sum2 it displays 0, when used with sum1 or numbers Int.32 error
//Array.ForEach(sum1, delegate(int i) { sum2 += i; });
foreach (int i in numbers)
sum2 =+ i;
Console.WriteLine("The sum of the values in your array is: " + sum1);
/*tried changing 'numbers' to sum1, sum2, sum1.Convert.ToString(),sum2.Convert.ToString()
numbers.Convert.ToString(), also tried converting sum2 to a string.*/
}
}
}
Here is my final solution!
static void Main(string[] args)
{
AskUserForNumbers();
Console.WriteLine("Press any key to exit");
Console.ReadLine();
}
public static List<Int32> AskUserForNumbers()
{
bool running = true;
List<int> numbers = new List<int>();
while (running)
{
Console.Write("Enter a number or enter 999 to exit: ");
int inputValue;
var inputString = Console.ReadLine();
//Check for "999" which indicates we should display the numbers entered, the total and then exit our loop.
if (inputString == "999")
{
Console.WriteLine("The sum of the values in your array is: " + numbers.Sum());
running = false;
}
else if (Int32.TryParse(inputString, out inputValue) && inputValue > 0)
{
numbers.Add(inputValue);
}
else
{
Console.WriteLine("Please enter a whole number greater than 0");
}
}
return numbers;
}
}
}
A few problems:
First, you're always declaring your arrays as int[] array1 = new int[0];. This means that your code for actually getting the user input will never hit. Maybe you should try using a different collection type (List<int> maybe).
Second, you never perform any error checking when parsing the integer. That's bad practice. You should be using int.TryParse(string input, out result) to verify it was a valid number before adding it to the array.
Third, you are looping over the length of the array for inputs, meaning you will loop through however long the array is, and will continue doing so until the last input you have is the exit number (999).
Fourth, the input you get for the exit code is discarded (not added to the array to sum).
Just remember that programming is very procedural. There should be clear (logical) steps from point a to point b. In fact, imagine you are the program and you're asking a friend to give you numbers to sum up for him. Give him whatever information you think might be useful (such as the exit condition). Diagram the steps, and then try to translate that to code.
Edit: The main point is that an array (which has a fixed size) is NOT the tool for the job here. You're not actually filling the array with any data, so that's why the sum never happens. The culprit is here:
int[] array1 = new int[0]; // Instantiate a zero-length array? Can't hold any values
// Will never hit inside the loop here, because i < array1.Length (which is zero) will always be false.
for (i = 0; i < array1.Length; i++)
You need to either increase the size of the array to begin with (and either reuse the indexes or resize the array) or use an non-fixed collection (List, for example). Finally, when you pass array1 to the Sum method, array1 is empty because you declared it as a zero element array. That is why you always get a zero printing out. Like I said before, imagine you are the program, and actually run through all these steps, LINE BY LINE.
For example, you start in the loop. You prepare a miniature notebook to write down all the numbers your friend is telling you with no pages in it. For every page (and realize there are none) in the notebook, you ask your friend for a number. After you've gone through every page, you now go through every page again to read all the values he gave you (keep in mind he couldn't give you any numbers, since the notebook was empty). Then you ask him one more time for a number, and if it's 999 you tell him you're done and give him the sum of all the numbers you wrote down. If he didn't give you 999 as the number, you repeat the cycle.
Do you understand WHY it's not working now?
public static void Sum(int[] numbers)
{
int sum2 = 0;
foreach (int i in numbers)
sum2 =+ i;
Console.WriteLine("The sum of the values in your array is: " + sum2);
}
foreach (int i in numbers)
sum2 =+ i;
should become
foreach (int i in numbers)
sum2 += i;
Your problem is with your first for loop. You never will add items to your array because your
for (i = 0; i < array1.Length; i++)
Since you only add to your array1 array when you enter the loop, it won't ever increment. Since i = 0 and the array1.Length is 0 to start, i will never be less than the length.
Here is what I would suggest you do.
private static void Main(string[] args) {
var running = true;
var numbers = new List<int>();
//Enter Question Asking Loop w/ running=true
while (running) {
Console.Write("Enter a number or enter 999 to exit: ");
int inputValue;
var inputString = Console.ReadLine();
//Check for "999" which indicates we should display the numbers entered, the total and then exit our loop.
if (inputString == "999") {
//Display the numbers entered
foreach (var number in numbers) {
Console.WriteLine(number);
}
Console.WriteLine("The sum of the values in your array is: " + numbers.Sum());
running = false;
}
else if (Int32.TryParse(inputString, out inputValue) && inputValue > 0) {
//We have valid input, append it to our collection
numbers.Add(inputValue);
}
else {
//The user entered invalid data. Let them know.
Console.WriteLine("Please enter a whole number greater than 0");
}
}
//Loop complete
Console.WriteLine("Press any key to exit.");
Console.ReadLine();
}
You have several small mistakes here.
In your Sum method you are no longer using the array sum1, you're summing the values into sum2, but you're printing sum1. Your sum method should be (as described by Wiktor):
public static void Sum(int[] numbers)
{
int sum2 = 0;
foreach (int i in numbers)
sum2 += i;
Console.WriteLine("The sum of the values in your array is: " + sum2);
}
Also note that you used sum2 =+ i rather than sum2 =+ i. What that's saying is "set sum2 to be equal to the positive value of i" rather than, "add i to sum2.
Next, you have some issues in how you gather your input from the user. First off, arrays don't have a mutable size. The size that they have is fixed when they are created, and the array that you create to hold onto the values to sum up from the users is initialized to a size of 0. (int[] array1 = new int[0];) If you want to get a fixed number of values from the user you can put something other than 0 there for the array size, but based on the context it appears that you want the users to be able to add values until they enter 999 at which point you end. Since you don't know the size before hand you'll want to use a List<int> rather than an array, as you can just add items to it and it will magically grow to support the new items.
I would also suggest making a new method to get all of the values from the user, rather than embedding it in your Main method.
public static List<int> AskUserForNumbers()
{
List<int> numbers = new List<int>();
while(...)//todo determine end condition
{
string userInput = Console.ReadLine();
if(...)//todo determine if user is done
{
}
else
{
int nextNumber = ...;//todo parse user input
numbers.Add(nextNumber);
}
}
return numbers;
}
I'm not sure if it's a requirement for you to stop asking for numbers when the user enters 999 or if that's just what you did. if you have a choice, I would suggest using something different such as a blank line, 0, "quit", "exit", etc. 999 is a number that someone might want to sum.
As mentioned by SPFiredrake, it's best to use int.TryParse() to parse user input, that way if they enter a number that's not an int it won't crash, and you can tell the user that it was no good and they need to try again.

Categories