The Problem
I am currently following Brackeys' First Person movement tutorial. However, I'm still stuck on the camera step as unlike most people having camera movement errors, I can only move my camera up and down (as opposed to only left and right).
The Code
using System.Collections;
using System.Collections.Generic;
using System.Collections.Specialized;
using UnityEngine;
public class mouselook : MonoBehaviour
{
public float mouseSensitivity = 100f;
public Transform playerBody;
float xRotation = 0f;
// Start is called before the first frame update
void Start()
{
}
// Update is called once per frame
void Update()
{
float mouseX = Input.GetAxis("Mouse X") * mouseSensitivity * Time.deltaTime;
float mouseY = Input.GetAxis("Mouse Y") * mouseSensitivity * Time.deltaTime;
xRotation -= mouseY;
xRotation = Mathf.Clamp(xRotation, -90f, 90f);
transform.localRotation = Quaternion.Euler(xRotation, 0f, 0f);
playerBody.Rotate(Vector3.up * mouseX);
}
}
(the script is stored in the camera. playerBody links to a cylinder mesh.)
Every time you call transform.localRotation = Quaternion.Euler(xRotation, 0f, 0f); you are resetting the y and z of the euler back to 0. I changed the update function to:
void Update()
{
float mouseX = Input.GetAxis("Mouse X") * mouseSensitivity * Time.deltaTime;
float mouseY = Input.GetAxis("Mouse Y") * mouseSensitivity * Time.deltaTime;
playerBody.Rotate(Vector3.up * mouseX);
playerBody.Rotate(Vector3.up * mouseX);
}
And I got more expected behavior. I didn't watch the tutorial you are talking about so it may be fixed/explained further on.
Related
I am new to programming and currently working on a little shooter game in unity. I just implemented recoil but my "PlayerCam" script (Line 31: transform.rotation = Quaternion.Euler(xRotation, yRotation, 0);) interrupts my "Recoil" script, the Euler function to be exact. Without this line recoil works, but I cant move obviously. With it the screen just shakes a bit (reset every frame and not continuing the recoil). What do i need to change?
PlayerCam.cs
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class PlayerCam : MonoBehaviour
{
public float sensX;
public float sensY;
public Transform orientation;
float xRotation;
float yRotation;
private void Start()
{
Cursor.lockState = CursorLockMode.Locked;
Cursor.visible = false;
}
private void Update()
{
float mouseX = Input.GetAxis("Mouse X") * sensX;
float mouseY = Input.GetAxis("Mouse Y") * sensY;
yRotation += mouseX;
xRotation -= mouseY;
xRotation = Mathf.Clamp(xRotation, -90f, 90f);
transform.rotation = Quaternion.Euler(xRotation, yRotation, 0);
orientation.rotation = Quaternion.Euler(0, yRotation, 0);
}
}
Recoil.cs
using UnityEngine;
public class Recoil : MonoBehaviour
{
private Vector3 currentRotation;
private Vector3 targetRotation;
[SerializeField] private float recoilX;
[SerializeField] private float recoilY;
[SerializeField] private float recoilZ;
[SerializeField] private float snappiness;
[SerializeField] private float returnSpeed;
void Start()
{
}
void Update()
{
targetRotation = Vector3.Lerp(targetRotation, Vector3.zero, returnSpeed * Time.deltaTime);
currentRotation = Vector3.Slerp(currentRotation, targetRotation, snappiness * Time.fixedDeltaTime);
transform.localRotation = Quaternion.Euler(currentRotation);
}
public void RecoilFire()
{
targetRotation += new Vector3(recoilX, Random.Range(-recoilY, recoilY), Random.Range(-recoilZ, recoilZ));
}
}
Thank you for your help :)
I'm not sure where your Recoil class comes in as far as modifying your PlayerCam's orientation, but it sounds like your camera is being hard-reset to the value of the player's turn angles every frame, rather than combining them with the current recoil (sometimes called "punch") values.
To do a recoil/viewpunch setup correctly, you'll need to give your camera class access to an orientation that represents the current amount of rotation caused by the recoil, and combine that with the camera's current player angle setup.
Something like:
// get your current recoil offset here
Quaternion viewPunch = MyRecoil.transform.rotation;
// update the "base" rotation, aka where the player is looking
// (your existing code)
float mouseX = Input.GetAxis("Mouse X") * sensX;
float mouseY = Input.GetAxis("Mouse Y") * sensY;
yRotation += mouseX;
xRotation -= mouseY;
xRotation = Mathf.Clamp(xRotation, -90f, 90f);
// final camera rotation = viewPunch * player angles.
// to rotate an orientation, we always do rotation * current,
// not the other way around.
// if the strength of the recoil has gone back to 0 or hasn't
// happened yet, we'll end up with the normal player angles,
// as expected.
// if your camera object is a child of another object, you may need to set localRotation instead
transform.rotation = viewPunch * Quaternion.Euler(xRotation, yRotation, 0);
**```
I am making a game in which you control a machine gun and attempt to kill enimies. There is no actual player, but only a camera. I needed a first person aspect to the game, so I added some simple script to level 1. If you lose, the level is reset. But, whenever you run it, the cameras rotation gets set off, even though its set to 0,0,0. After you die and respawn, for some reason, the camera is normal and the scene is reset. I also noticed that the camera is at an angle sometimes
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.SceneManagement;
public class CrosshairMove : MonoBehaviour
{
public float sens = 100f;
public Rigidbody rb;
public Transform cam;
float xRotation = 0f;
float yRotation = 0f;
public float sceneused = 0f;
public float currentscene = 0f;
void Start()
{
Cursor.lockState = CursorLockMode.Locked;
}
void FixedUpdate()
{
float mouseX = Input.GetAxis("Mouse X") * sens * Time.deltaTime;
float mouseY = Input.GetAxis("Mouse Y") * sens * Time.deltaTime;
xRotation -= mouseY;
yRotation -= mouseX;
//xRotation -= Mathf.Clamp(xRotation, -90f, 90f);
//transform.localRotation = Quaternion.Euler(xRotation, 0f, 0f);
cam.Rotate(Vector3.up * mouseX);
cam.Rotate(Vector3.left * mouseY);
}
}
I would:
Try different gameObject for independent rotation and avoid gimbal lock. For this, you can put the camera in the child object, and when parent is rotated in its local axis, the children "suffers" that same rotation.
Clamp xrot 180º is usual thing in FPS camera
Use FixedUpdate only for physics. For anything else use normal Update
Suggested snippet with all of the above:
public GameObject parentGO; // drag ref to parent go here in the editor
void Update {
float mouseX = Input.GetAxis("Mouse X") * lookAtSensitivity * Time.deltaTime;
float mouseY = Input.GetAxis("Mouse Y") * lookAtSensitivity *
Time.deltaTime;
xRot -= mouseY;
xRot = Mathf.Clamp(xRot, -90f, 90f);
transform.localRotation = Quaternion.Euler(xRot, 0f, 0f);
parentGO.transform.Rotate(Vector3.up * mouseX);
}
I am following a first person tutorial on brackeys youtube
channel. This is the link:
https://www.youtube.com/watch?v=_QajrabyTJc
The tutorial requires me to lock my cursor but my cursor doesn't lock, I can move anywhere I would like to. The tutorial is a bit outdated so I am not sure if the code is too.
Here is the code:
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class MouseLook : MonoBehaviour
{
public float mouseSensitivity = 100f;
public Transform playerBody;
float xRotation = 0f;
void Start()
{
Cursor.lockState = CursorLockMode.Locked;
}
// Update is called once per frame
void Update()
{
float mouseX = Input.GetAxis("Mouse X") * mouseSensitivity * Time.deltaTime;
float mouseY = Input.GetAxis("Mouse Y") * mouseSensitivity * Time.deltaTime;
xRotation -= mouseY;
xRotation = Mathf.Clamp(xRotation, -90f, 90f);
transform.localRotation = Quaternion.Euler(xRotation, 0f, 0f);
playerBody.Rotate(Vector3.up * mouseX);
}
}
I have applied the script onto my camera if this information is needed.
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class CameraControl : MonoBehaviour
{
[SerializeField]float mouseSensitivity;
private Transform parent;
Vector2 turn;
// Start is called before the first frame update
void Start()
{
parent = transform.parent;
Cursor.lockState = CursorLockMode.Locked;
}
// Update is called once per frame
void Update()
{
Rotate();
}
void Rotate(){
float mousex = Input.GetAxis("Mouse X") * mouseSensitivity * Time.deltaTime;
parent.Rotate(Vector3.up, mousex);
float mousey = -Input.GetAxis("Mouse Y") * mouseSensitivity * Time.deltaTime; ///.deltaTime;
parent.Rotate(Vector3., mousey);
// turn.x += Input.GetAxis("Mouse X") * mouseSensitivity * Time.deltaTime;
// turn.y += Input.GetAxis("Mouse Y") * mouseSensitivity * Time.deltaTime;
// transform.localRotation = Quaternion.Euler(-turn.y, turn.x, 0);
}
}
This is the code for the camera I have written and been on it for like a day but don't know that much about coding so all I see just confuses me. Basically trying to make the camera move up and down with the mouse but it isn't working but the left and right are walking
Try Replace
float mousey = -Input.GetAxis("Mouse Y") * mouseSensitivity * Time.deltaTime;
///.deltaTime;
parent.Rotate(Vector3., mousey);
with
float mousey = -Input.GetAxis("Mouse Y") * mouseSensitivity * Time.deltaTime;
///.deltaTime;
parent.Rotate(Vector3.right, mousey);
or
float mousey = -Input.GetAxis("Mouse Y") * mouseSensitivity * Time.deltaTime;
///.deltaTime;
parent.Rotate(Vector3.forward, mousey);
I'm having a problem moving my character’s mouse in particular on x-axi.
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class movimentoRato : MonoBehaviour
{
public float sensibilidade = 100f;
public Transform playerBody;
float xRotation = 0f;
void Start()
{
Cursor.lockState = CursorLockMode.Locked;
}
// Update is called once per frame
void Update()
{
float mouseX = Input.GetAxis("Mouse X") * sensibilidade * Time.deltaTime;
float mouseY = Input.GetAxis("Mouse Y") * sensibilidade * Time.deltaTime;
xRotation -= mouseY;
xRotation = Mathf.Clamp(xRotation, -90f, 90f);
transform.localRotation = Quaternion.Euler(xRotation, 0f, 0f);
playerBody.Rotate(Vector3.up * mouseX);
}
}
Mouse x-axis is locked can somebody help me?
float mouseX = Input.GetAxis("Mouse X") * 2.75f;
float mouseY = Input.GetAxis("Mouse Y") * 2.75f;
xRotation -= mouseY;
xRotation = Mathf.Clamp(xRotation, -90f, 90f);
transform.localRotation = Quaternion.Euler(xRotation, 0f, 0f);
playerBody.Rotate(Vector3.up * mouseX);