C# Create instance, call method and assign return variable in one line - c#

Assume the following code:
DeviceCommunicationDao dao = new DeviceCommunicationDao();
var device = dao.GetDeviceById(123); //returns an object of type "Device"
So I want to assign 2 variables. Is there a way to do this in one line? I mean generally, like via a generic extension method?
Something like this:
var device = (new DeviceCommunicationDao() as DeviceCommunicationDao dao).GetDeviceById(123);
I am not looking for lectures on how this is a bad idea and what is confusing or not. I am looking for a one-liner that instantiates 2 variables with a generic approach.
Cheers!

If you really want you can create something based on tuples + deconstruction + passing in a Func. For example:
// in case of using `new()` generic constraint both generic params should be specified
var (dao, device) = CreateAndInvoke<DeviceCommunicationDao, int>(d => d.GetDeviceById(123));
static (T, TResult) CreateAndInvoke<T, TResult>(Func<T, TResult> f) where T : new()
{
var t = new T();
return (t, f(t));
}
Or via providing factory:
var (dao, device) = CreateAndInvoke(() => new DeviceCommunicationDao(),d => d.GetDeviceById(123));
static (T, TResult) CreateAndInvoke<T, TResult>(Func<T> fact, Func<T, TResult> f)
{
var t = fact();
return (t, f(t));
}
Or just passing an created instance:
var (dao, device) = InvokeAndReturnBoth(new DeviceCommunicationDao(), d => d.GetDeviceById(123));
static (T, TResult) InvokeAndReturnBoth<T, TResult>(T inst, Func<T, TResult> f)
=> (inst, f(inst));
Though I would not say that this is much more readable/convenient.

Related

How to build a properties selector?

I was trying to make an Update function with the following format:
public int Update(
Item Item,
Expression<Func<Item, object>> selector)
How can I read what properties are selected within the selector? I need the names of the properties.
This is because I want to make the update function smarter so it updates only what has to be updated. It's for sql and it's a repository function.
Thanks.
Update for clarification:
I want to be able to call Update like this:
Update(item, x => new { x.Property1, x.Property2 })
So IEnumerable of expressions is not an option but if the above is a lot more difficult I'll do that...
Assuming you don't want to verify that the expressions actually return a property value, this would work:
public int Update(Item item, params Expression<Func<Item, object>>[] selectors)
{
var propertyNames = selectors
.Select(expression => ((MemberExpression)expression.Body).Member.Name);
// ...
}
Otherwise you would need to something akin to this comprehensive answer.
Update
If you want to use anonymous objects, then you could do something like this:
public int Update<TProps>(Item item, Expression<Func<Item, TProps>> selector)
{
var propertyNames = typeof(TProps)
.GetProperties()
.Select(prop => prop.Name);
// ...
}
Although this could be easily misused.
If you don't mind writing the update code as Update(item, x => x.Property1, x=> x.Property2 ), it would be just as readable and a bit easier to write, as shown by Johnathans answer.
Although if you add a generic, you can force x to be of the same type and reuse it for different objects besides Item
int Update<T>(T item, params Expression<Func<T, object>>[] selectors)
{
string getName(Expression e)
{
if(e is LambdaExpression l)
return getName(l.Body);
if(e is MemberExpression m)
return m.Member.Name;
if(e is UnaryExpression u)
return getName( u.Operand);
throw new NotImplementedException();
}
var names = selectors.Select(getName);
//update code...
}
NB, the helper function is a basic one, you can use a more extended reusable helper function to get the name, plenty of those around
Example code (the first anonymous object is just to create an example object):
Update(new { foo = "a", bar = 5}, x=>x.foo, x=>x.bar);
Now the funny thing is, you can either force a single expression by removing the new, or you could combine that function, and still allow anonymous, by adding a check for a NewExpression inside the helper function (changing it to allow for multiple names of course):
int Update<T>(T item, params Expression<Func<T, object>>[] selectors)
{
IEnumerable<string> getName(Expression e)
{
if (e is LambdaExpression l)
return getName(l.Body);
if (e is MemberExpression m)
return new[] { m.Member.Name };
if (e is UnaryExpression u)
return getName(u.Operand);
if (e is NewExpression n) // <- to account for the anonymous object
return n.Arguments.SelectMany(getName);
throw new NotImplementedException();
}
var names = selectors.SelectMany(getName);
// etc
}
That way, you can choose (or even mix). Both these calls produce the same:
Update(new { foo = "a", bar = 5}, x=>x.foo, x=>x.bar);
Update(new { foo = "a", bar = 5 }, x => new { x.foo, x.bar});

Overloading with 'different' return type

I have always read that overloaded methods should always return the same type whenever possible.
However I've come upon a scenario which I really don't know if it could be considered as having different return types or not.
Consider the following implementation to obtain the permutations of all elements of a given collection taken k at a time where the elements the make up the permutation are aggregated to the consumer's needs.
public static IEnumerable<Q> GetPermutations<T, Q>(this IEnumerable<T> collection, int k, Func<IEnumerable<T>, Q> aggregator)
{
if (k <= 0)
return Enumerable.Empty<Q>();
return collection.getPermutations(k).Select(p => aggregator(p));
}
private static IEnumerable<IEnumerable<T>> getPermutations<T>(this IEnumerable<T> set, int k) =>
k == 0 ? new[] { Enumerable.Empty<T>() }
: set.SelectMany((item, index) => set.SkipAt(index).getPermutations(k - 1).Select(p => new[] { item }.Concat(p)));
private static IEnumerable<T> SkipAt<T>(this IEnumerable<T> collection, int index)
{
var counter = 0;
foreach (var item in collection)
{
if (counter != index)
{
yield return item;
}
counter++;
}
}
Now I want to define an overload that takes no aggregator and simply returns each permutation as an IEnumerable<T>.
My first implementation looked as follows:
public static IEnumerable<IEnumerable<T>> GetPermutations<T>(this IEnumerable<T> collection, int k)
=> GetPermutations(collection, k, p => p);
Pretty straightforward. But then I realized that I am in someway changing the return type of the method. If inspected in intellisense, the first returns IEnumerable<Q> while the second returns IEnumerable<IEnumerable<T>> and the type parameter Q dissapears.
Should this be any cause of concern? Can it create confussion and should be avoided if possible? Technically the return type does not change, as IEnumerable<IEnumerable<T>> is an IEnumerable<Q> but it still caught my eye when reviewing the code as I don't recall seeing anything similar before.
The workaround I immediately thought of was to make aggregator optional, but this runs into its own problems:
public static IEnumerable<Q> GetPermutations<T, Q>(this IEnumerable<T> collection, int k, Func<IEnumerable<T>, Q> aggregator = null)
{
if (k <= 0)
return Enumerable.Empty<Q>();
var myAggregator = aggregator ?? new Func<IEnumerable<T>, Q)(p => p); //Compile time error, no implicit conversion from `IEnumerable<T>` to `Q`
return collection.getPermutations(k).SelectMany(p => new[] { myAggregator(p) });
}
Note that the second type parameter Q is necessary due to our needs and the corner case provided by string being an IEnumerable<char>. An aggregator of type Func<IEnumerable<T>, T> for instance would not work:
var str = "1234";
var permutations = str.GetPermutations(4, p => Concat(p)); // compile time error, `string` is not a `char`.
Is the proposed overload acceptable or is there a workaround I am not considering available to make the optional argument solution work?

Lambdaexpression of Linq-query in a variable

How can I define a lambdaexpression that I want to use in a linq query as a variable?
For example when sorting a generic list by different properties of the listitems:
IList<SampleClass> list = new List<SampleClass>();
// Populate list
...
list.OrderBy(sampleclass => sampleclass.property1);
list.OrderBy(sampleclass => sampleclass.property2);
I would like to define the lambda expression (sampleclass => sampleclass.property1) in a variable and call:
// ??? define expression in a variable ???
Expression expression = sampleclass => sampleclass.property1;
// Sort list by variable expression
list.OrderBy(expression);
Thanks in advance
Tobi
You can use one of Func overloads (Func<T, TResult> precisely):
Func<SampleClass, PropertyType> expr = sampleclass => sampleclass.property1;
list.OrderBy(expr);
PropertyType is the type of variable stored as property1 in your SampleClass. If it was for example string, you would use Func<SampleClass, string>.
Define a Func<TSampleClass, TPropertyType> as follows:
List<SampleClass> list = new List<SampleClass>();
Func<SampleClass, int> expr = (c) => c.SomeProperty;
_HungerLevel = level;
class SampleClass
{
public int SomeProperty { get; set; }
}
You can use:
Func<SampleClass, int> f = sampleClass => sampleClass.Property1;
list.OrderBy(f);
This presumes the type of Property1 is int.
You have almost already done it.
The parameter is any function taking an item from the sequence and giving its key as a result (the key on which the ordering will be done). A lambda expression is just a variety of such a function.
These notations are possible :
list.OrderBy(sampleclass => sampleclass.property1);
or
Func<SampleClass,string> getKey = sampleclass => sampleclass.property1;
list.OrderBy(getKey);
or
string GetKey(SampleClass sampleclass)
{
return sampleclass.property1;
}
list.OrderBy(GetKey);
(I supposed here that property1 was a string but it's of course not a requirement !)
Just like other people said, you can use Func<T, TResult> to store delegate to your function.
If you want to use something else than Linq-To-Objects, then you should enclose this in Expression too. Something like Expression<Func<T, TResult>>.
If you are talking purely about LINQ to Objects, there's no need for Expressions here because the argument to Enumerable.OrderBy is a Func delegate:
var list = new List<SampleClass> ();
Func<SampleClass, PropertyType1) orderSelector1 = (obj => obj.Property1); // parentheses for clarity
var sequence1 = list.OrderBy (orderSelector1);
Func<SampleClass, PropertyType2) orderSelector1 = (obj => obj.Property2);
var sequence2 = list.OrderBy (orderSelector2);
If you want to assign multiple times, you can make Func return object:
var list = new List<SampleClass> ();
Func<SampleClass, object> orderSelector;
orderSelector = (obj => obj.Property1);
var sequence1 = list.OrderBy (orderSelector);
orderSelector = (obj => obj.Property2);
var sequence2 = list.OrderBy (orderSelector);
If you truly want dynamic property selection, i.e. calling OrderBy with a property specified by a string, you would need Expressions. There are plenty of examples in this thread that allow you to do something like:
var list = new List<SampleClass> ();
var sequence1 = list.OrderBy ("Property1");
var sequence2 = list.OrderBy ("Property2");

Call Generic Method with an anonymous Type (C#)

Let's just say I'd like to iterate over a string[][], append a value using an anonymous type and perform a generic ForEach-Extensionmethod on the result (brilliant example, I know, but I suppose you'll get the jist of it!).
Here's my code:
//attrs = some string[][]
attrs.Select(item => new { name = HttpContext.GetGlobalResourceObject("Global", item[0].Remove(0, 7)), value = item[1] })
.ForEach</*????*/>(/*do stuff*/);
What exactly would I put in the Type-Parameter of ForEach?
Here's what ForEach looks like:
public static void ForEach<T>(this IEnumerable<T> collection, Action<T> act)
{
IEnumerator<T> enumerator = collection.GetEnumerator();
while (enumerator.MoveNext())
act(enumerator.Current);
}
You don't need to specify the type explicitly, because it can be inferred from the supplied parameters:
attrs.Select(item => new
{
name = HttpContext.GetGlobalResourceObject("Global",
item[0].Remove(0, 7)),
value = item[1]
})
.ForEach(x => x.name = "something");

Select Right Generic Method with Reflection

I want to select the right generic method via reflection and then call it.
Usually this is quite easy. For example
var method = typeof(MyType).GetMethod("TheMethod");
var typedMethod = method.MakeGenericMethod(theTypeToInstantiate);
However the issue start when there are different generic overloads of the method. For example the static-methods in the System.Linq.Queryable-class. There are two definitions of the 'Where'-method
static IQueryable<T> Where(this IQueryable<T> source, Expression<Func<T,bool>> predicate)
static IQueryable<T> Where(this IQueryable<T> source, Expression<Func<T,int,bool>> predicate)
This meand that GetMethod doesn't work, because it cannot destiguish the two. Therefore I want to select the right one.
So far I often just took the first or second method, depending on my need. Like this:
var method = typeof (Queryable).GetMethods().First(m => m.Name == "Where");
var typedMethod = method.MakeGenericMethod(theTypeToInstantiate);
However I'm not happy with this, because I make a huge assumption that the first method is the right one. I rather want to find the right method by the argument type. But I couldn't figure out how.
I tried it with passing the 'types', but it didn't work.
var method = typeof (Queryable).GetMethod(
"Where", BindingFlags.Static,
null,
new Type[] {typeof (IQueryable<T>), typeof (Expression<Func<T, bool>>)},
null);
So has anyone an idea how I can find the 'right' generic method via reflection. For example the right version of the 'Where'-method on the Queryable-class?
You can somewhat elegantly select a specific generic overload of a method at compile-time, without passing any strings to run-time searches like the other answers here do.
Static Methods
Suppose you have multiple static methods of the same name like:
public static void DoSomething<TModel>(TModel model)
public static void DoSomething<TViewModel, TModel>(TViewModel viewModel, TModel model)
// etc
If you create an Action or Func that matches the generic count and parameter count of the overload you're looking for, you can select it at compile-time with relatively few acrobatics.
Example: Select the first method - returns void, so use an Action, takes one generic. We use object to avoid specifying type just yet:
var method = new Action<object>(MyClass.DoSomething<object>);
Example: Select the second method - returns void, so Action, 2 generic types so use type object twice, once for each of the 2 generic parameters:
var method = new Action<object, object>(MyClass.DoSomething<object, object>);
You just got the method you wanted without doing any crazy plumbing, and no run-time searching or usage of risky strings.
MethodInfo
Typically in Reflection you want the MethodInfo object, which you can also get in a compile-safe way. This is when you pass the actual generic types you want to use in your method. Assuming you wanted the second method above:
var methodInfo = method.Method.MakeGenericMethod(type1, type2);
There's your generic method without any of the reflection searching or calls to GetMethod(), or flimsy strings.
Static Extension Methods
The specific example you cite with Queryable.Where overloads forces you to get a little fancy in the Func definition, but generally follows the same pattern. The signature for the most commonly used Where() extension method is:
public static IQueryable<TModel> Where<TModel>(this IQueryable<TModel>, Expression<Func<TModel, bool>>)
Obviously this will be slightly more complicated - here it is:
var method = new Func<IQueryable<object>,
Expression<Func<object, bool>>,
IQueryable<object>>(Queryable.Where<object>);
var methodInfo = method.Method.MakeGenericMethod(modelType);
Instance Methods
Incorporating Valerie's comment - to get an instance method, you'll need to do something very similar. Suppose you had this instance method in your class:
public void MyMethod<T1>(T1 thing)
First select the method the same way as for statics:
var method = new Action<object>(MyMethod<object>);
Then call GetGenericMethodDefinition() to get to the generic MethodInfo, and finally pass your type(s) with MakeGenericMethod():
var methodInfo = method.Method.GetGenericMethodDefinition().MakeGenericMethod(type1);
Decoupling MethodInfo and Parameter Types
This wasn't requested in the question, but once you do the above you may find yourself selecting the method in one place, and deciding what types to pass it in another. You can decouple those 2 steps.
If you're uncertain of the generic type parameters you're going to pass in, you can always acquire the MethodInfo object without them.
Static:
var methodInfo = method.Method;
Instance:
var methodInfo = method.Method.GetGenericMethodDefinition();
And pass that on to some other method that knows the types it wants to instantiate and call the method with - for example:
processCollection(methodInfo, type2);
...
protected void processCollection(MethodInfo method, Type type2)
{
var type1 = typeof(MyDataClass);
object output = method.MakeGenericMethod(type1, type2).Invoke(null, new object[] { collection });
}
One thing this especially helps with is selecting a specific instance method of a class, from inside the class, then exposing that to outside callers who need it with various types later on.
Addendum
A number of comments below say they cannot get this to work. It might not be surprising that I don't often have to select a generic method like this, but I happen to be doing so today, in well-tested code used behind the scenes all the time, so I thought I'd provide that real-world example - and perhaps it will help those who struggle to get this to work.
C# lacks a Clone method, so we have our own. It can take a number of arguments, including those that explain how to recursively copy IEnumerable properties inside the source object.
The method that copies an IEnumerable is named CopyList, and looks like this:
public static IEnumerable<TTo> CopyList<TTo>(
IEnumerable<object> from,
Func<PropertyInfo, bool> whereProps,
Dictionary<Type, Type> typeMap
)
where TTo : new()
{
To complicate things (and flex the muscles of this approach), it has several overloads, like this one:
public static IEnumerable<TTo> CopyList<TTo>(
IEnumerable<object> from,
Dictionary<Type, Type> typeMap
)
where TTo : new()
{
So, we've got several (I'm only showing you 2, but there are more in the code) method signatures. They have the same number of Generic arguments, but a different number of method arguments. The names are identical. How are we possibly going to call the right method? Begin the C# ninjaing!
var listTo = ReflectionHelper.GetIEnumerableType(
fromValue.GetType());
var fn = new Func<
IEnumerable<object>,
Func<PropertyInfo, bool>,
Dictionary<Type, Type>,
IEnumerable<object>>(
ModelTransform.CopyList<object>);
var copyListMethod = fn.GetMethodInfo()
.GetGenericMethodDefinition()
.MakeGenericMethod(listTo);
copyListMethod.Invoke(null,
new object[] { fromValue, whereProps, typeMap });
The first line uses a helper method we'll come back to, but all it's doing is getting the generic type of the IEnumerable list in this property, and assigning it to listTo. The next line is where we really begin performing this trick, where we lay out a Func with adequate parameters to match up with the specific CopyList() overload we intend to grab. Specifically, the CopyList() we want has 3 arguments, and returns IEnumerable<TTo>. Remember that Func takes its return type as its last generic arg, and that we're substituting object wherever there's a generic in the method we intend to grab. But, as you can see in this example, we do not need to substitute object anywhere else. For example, we know we want to pass a where clause that accepts a PropertyInfo and returns true/false (bool), and we just say those types right in the Func.
As the constructor arg to the Func, we pass CopyList() - but remember that the name CopyList is vague because of the method overloads. What's really cool is that C# is doing the hard work for you right now, by looking at the Func args, and identifying the right one. In fact, if you get the types or number of args wrong, Visual Studio will actually mark the line with an error:
No overload for 'CopyList' matches delegate 'Func...'
It's not smart enough to tell you what exactly you need to fix, but if you see that error you're close - you need to carefully double-check the args and return type and match them up exactly, replacing Generic args with object.
On the third line, we call the C# built-in .GetMethodInfo() and then .MakeGeneric(listTo). We have only one Generic to set for this, so we pass that in as listTo. If we had 2, we'd pass 2 args here. These Type args are replacing the object substitutions we made earlier.
And that's it - we can call copyListMethod(), with no strings, fully compile-safe. The final line makes the call, first passing null because it's a static method, then an object[] array with the 3 args. Done.
I said I'd come back to the ReflectionHelper method. Here it is:
public static Type GetIEnumerableType(Type type)
{
var ienumerable = type.GetInterface(typeof(System.Collections.Generic.IEnumerable<>).FullName);
var generics = ienumerable.GetGenericArguments();
return generics[0];
}
It can be done, but it's not pretty!
For example, to get the first overload of Where mentioned in your question you could do this:
var where1 = typeof(Queryable).GetMethods()
.Where(x => x.Name == "Where")
.Select(x => new { M = x, P = x.GetParameters() })
.Where(x => x.P.Length == 2
&& x.P[0].ParameterType.IsGenericType
&& x.P[0].ParameterType.GetGenericTypeDefinition() == typeof(IQueryable<>)
&& x.P[1].ParameterType.IsGenericType
&& x.P[1].ParameterType.GetGenericTypeDefinition() == typeof(Expression<>))
.Select(x => new { x.M, A = x.P[1].ParameterType.GetGenericArguments() })
.Where(x => x.A[0].IsGenericType
&& x.A[0].GetGenericTypeDefinition() == typeof(Func<,>))
.Select(x => new { x.M, A = x.A[0].GetGenericArguments() })
.Where(x => x.A[0].IsGenericParameter
&& x.A[1] == typeof(bool))
.Select(x => x.M)
.SingleOrDefault();
Or if you wanted the second overload:
var where2 = typeof(Queryable).GetMethods()
.Where(x => x.Name == "Where")
.Select(x => new { M = x, P = x.GetParameters() })
.Where(x => x.P.Length == 2
&& x.P[0].ParameterType.IsGenericType
&& x.P[0].ParameterType.GetGenericTypeDefinition() == typeof(IQueryable<>)
&& x.P[1].ParameterType.IsGenericType
&& x.P[1].ParameterType.GetGenericTypeDefinition() == typeof(Expression<>))
.Select(x => new { x.M, A = x.P[1].ParameterType.GetGenericArguments() })
.Where(x => x.A[0].IsGenericType
&& x.A[0].GetGenericTypeDefinition() == typeof(Func<,,>))
.Select(x => new { x.M, A = x.A[0].GetGenericArguments() })
.Where(x => x.A[0].IsGenericParameter
&& x.A[1] == typeof(int)
&& x.A[2] == typeof(bool))
.Select(x => x.M)
.SingleOrDefault();
This question is about 2 years old, but I came up with (what I think is) an elegant solution, and thought I'd share it with the fine folks here at StackOverflow. Hopefully it will help those who arrive here via various search queries.
The problem, as the poster stated, is to get the correct generic method. For example, a LINQ extension method may have tons of overloads, with type arguments nested inside other generic types, all used as parameters. I wanted to do something like this:
var where = typeof(Enumerable).GetMethod(
"Where",
typeof(IQueryable<Refl.T1>),
typeof(Expression<Func<Refl.T1, bool>>
);
var group = typeof(Enumerable).GetMethod(
"GroupBy",
typeof(IQueryable<Refl.T1>),
typeof(Expression<Func<Refl.T1, Refl.T2>>
);
As you can see, I've created some stub types "T1" and "T2", nested classes within a class "Refl" (a static class which contains all my various Reflection utility extension functions, etc. They serve as placeholders for where the type parameters would have normally went. The examples above correspond to getting the following LINQ methods, respectively:
Enumerable.Where(IQueryable<TSource> source, Func<TSource, bool> predicate);
Enumerable.GroupBy(IQueryable<Source> source, Func<TSource, TKey> selector);
So it should be clear that Refl.T1 goes where TSource would gone, in both of those calls; and the Refl.T2 represents the TKey parameter.The TX classes are declared as such:
static class Refl {
public sealed class T1 { }
public sealed class T2 { }
public sealed class T3 { }
// ... more, if you so desire.
}
With three TX classes, your code can identify methods containing up to three generic type parameters.
The next bit of magic is to implement the function that does the search via GetMethods():
public static MethodInfo GetMethod(this Type t, string name, params Type[] parameters)
{
foreach (var method in t.GetMethods())
{
// easiest case: the name doesn't match!
if (method.Name != name)
continue;
// set a flag here, which will eventually be false if the method isn't a match.
var correct = true;
if (method.IsGenericMethodDefinition)
{
// map the "private" Type objects which are the type parameters to
// my public "Tx" classes...
var d = new Dictionary<Type, Type>();
var args = method.GetGenericArguments();
if (args.Length >= 1)
d[typeof(T1)] = args[0];
if (args.Length >= 2)
d[typeof(T2)] = args[1];
if (args.Length >= 3)
d[typeof (T3)] = args[2];
if (args.Length > 3)
throw new NotSupportedException("Too many type parameters.");
var p = method.GetParameters();
for (var i = 0; i < p.Length; i++)
{
// Find the Refl.TX classes and replace them with the
// actual type parameters.
var pt = Substitute(parameters[i], d);
// Then it's a simple equality check on two Type instances.
if (pt != p[i].ParameterType)
{
correct = false;
break;
}
}
if (correct)
return method;
}
else
{
var p = method.GetParameters();
for (var i = 0; i < p.Length; i++)
{
var pt = parameters[i];
if (pt != p[i].ParameterType)
{
correct = false;
break;
}
}
if (correct)
return method;
}
}
return null;
}
The code above does the bulk of the work -- it iterates through all the Methods in a particular type, and compares them to the given parameter types to search for. But wait! What about that "substitute" function? That's a nice little recursive function that will search through the entire parameter type tree -- after all, a parameter type can itself be a generic type, which may contain Refl.TX types, which have to be swapped for the "real" type parameters which are hidden from us.
private static Type Substitute(Type t, IDictionary<Type, Type> env )
{
// We only really do something if the type
// passed in is a (constructed) generic type.
if (t.IsGenericType)
{
var targs = t.GetGenericArguments();
for(int i = 0; i < targs.Length; i++)
targs[i] = Substitute(targs[i], env); // recursive call
t = t.GetGenericTypeDefinition();
t = t.MakeGenericType(targs);
}
// see if the type is in the environment and sub if it is.
return env.ContainsKey(t) ? env[t] : t;
}
Another solution that you might find useful - it is possible to get a MethodInfo based on Expression.Call that already has a logic for overload resolution.
For example, in case you need to get some specific Enumerable.Where method that could be accomplished using the following code:
var mi = Expression.Call(typeof (Enumerable), "Where", new Type[] {typeof (int)},
Expression.Default(typeof (IEnumerable<int>)), Expression.Default(typeof (Func<int, int, bool>))).Method;
Third argument in the example - describes types of generic arguments, and all other arguments - types of parameters.
In the same way it is possible to get even non static object generic methods.You need to change only first argument from typeof (YourClass) to Expression.Default(typeof (YourClass)).
Actually, I have used that approach in my plugin for .NET Reflection API. You may check how it works here
Chris Moschini's answer is good when you know the method name in compile time. Antamir's answer works if we get method name in runtime, but is quite an overkill.
I am using another way, for which I got inspiration using reflector from .NET function Expression.Call, which selects correct generic method from a string.
public static MethodInfo GetGenericMethod(Type declaringType, string methodName, Type[] typeArgs, params Type[] argTypes) {
foreach (var m in from m in declaringType.GetMethods()
where m.Name == methodName
&& typeArgs.Length == m.GetGenericArguments().Length
&& argTypes.Length == m.GetParameters().Length
select m.MakeGenericMethod(typeArgs)) {
if (m.GetParameters().Select((p, i) => p.ParameterType == argTypes[i]).All(x => x == true))
return m;
}
return null;
}
Usage:
var m = ReflectionUtils.GetGenericMethod(typeof(Queryable), "Where", new[] { typeof(Person) }, typeof(IQueryable<Person>), typeof(Expression<Func<Person, bool>>));
If you need only generic method definition or simply do not know the type T at the time, you can use some bogus types and then strip the generic's information:
var m = ReflectionUtils.GetGenericMethod(typeof(Queryable), "Where", new[] { typeof(object) }, typeof(IQueryable<object>), typeof(Expression<Func<object, bool>>));
m = m.GetGenericMethodDefinition();
Let the compiler do it for you:
var fakeExp = (Expression<Func<IQueryable<int>, IQueryable<int>>>)(q => q.Where((x, idx) => x> 2));
var mi = ((MethodCallExpression)fakeExp.Body).Method.GetGenericMethodDefinition();
for the Where with index, or simply leave out the second parameter in the Where expression for the one without
In additional to #MBoros's answer.
You can avoid writing complex generic arguments using this helper method:
public static MethodInfo GetMethodByExpression<Tin, Tout>(Expression<Func<IQueryable<Tin>, IQueryable<Tout>>> expr)
{
return (expr.Body as MethodCallExpression).Method;
}
Usage:
var where = GetMethodByExpression<int, int>(q => q.Where((x, idx) => x > 2));
Or
var select = GetMethodByExpression<Person, string>(q => q.Select(x => x.Name));
Use DynamicMethods.GenericMethodInvokerMethod, GetMethod is not enough to use with generics
I made a little helper func:
Func<Type, string, Type[], Type[], MethodInfo> getMethod = (t, n, genargs, args) =>
{
var methods =
from m in t.GetMethods()
where m.Name == n && m.GetGenericArguments().Length == genargs.Length
let mg = m.IsGenericMethodDefinition ? m.MakeGenericMethod(genargs) : m
where mg.GetParameters().Select(p => p.ParameterType).SequenceEqual(args)
select mg
;
return methods.Single();
};
Works for simple non-generics:
var m_movenext = getMethod(typeof(IEnumerator), nameof(IEnumerator.MoveNext), Type.EmptyTypes, Type.EmptyTypes);
Like for complicated generics:
var t_source = typeof(fillin1);
var t_target = typeof(fillin2);
var m_SelectMany = getMethod(
typeof(Enumerable),
nameof(Enumerable.SelectMany),
new[] {
t_source,
t_target
},
new[] {
typeof(IEnumerable<>).MakeGenericType(t_source),
typeof(Func<,>).MakeGenericType(t_source, typeof(IEnumerable<>).MakeGenericType(t_target))
});
I have a similar issue and I thought I would post my solution here. I'm trying to call several functions:
p.Foo<Klass1>(true)
p.Foo<Klass2>(true)
p.Foo<Klass3>(true)
bool k1 = p.Bar<Klass1>()
bool k2 = p.Bar<Klass2>()
bool k3 = p.Bar<Klass3>()
My solution:
public static TAction RemapGenericMember<TAction>(object parent, Type target, TAction func) where TAction : Delegate {
var genericMethod = func?.Method?.GetGenericMethodDefinition()?.MakeGenericMethod(target);
if (genericMethod.IsNull()) {
throw new Exception($"Failed to build generic call for '{func.Method.Name}' with generic type '{target.Name}' for parent '{parent.GetType()}'");
}
return (TAction)genericMethod.CreateDelegate(typeof(TAction), parent);
}
And now I can call:
foreach(var type in supportedTypes) {
InvokeGenericMember<Action<bool>>(p, type, Foo<object>)(true);
bool x = InvokeGenericMember<Function<bool>>(p, type, Bar<object>)();
}
Antamir's answer was very useful for me, but it has a bug in that it doesn't validate that the number of parameters on the method found matches the number of types passed in when you provide a mix of generic and concrete types.
For example, if you ran:
type.GetMethod("MyMethod",typeof(Refl.T1),typeof(bool))
it can't differentiate between two methods:
MyMethod<T>(T arg1)
MyMethod<T>(T arg1, bool arg2)
The two calls to:
var p = method.GetParameters();
should be changed to:
var p = method.GetParameters();
if (p.Length != parameters.Length)
{
correct = false;
continue;
}
Also, both of the existing 'break' lines should be 'continue'.
I found out the easiest way to use iQuerable expressions while calling method using reflection. Please see below code:
You can use the IQuerable expression as per requirement.
var attributeName = "CarName";
var attributeValue = "Honda Accord";
carList.FirstOrDefault(e => e.GetType().GetProperty(attributeName).GetValue(e, null) as string== attributeValue);
var firstGenericParam = Type.MakeGenericMethodParameter(0);
var firstParam = typeof(IQueryable<>).MakeGenericType(firstGenericParam);
var funcType = typeof(Func<,>).MakeGenericType(firstGenericParam, typeof(bool));
//var funcType = typeof(Func<,,>).MakeGenericType(firstGenericParam, typeof(int), typeof(bool)); //for second version
var secondParam = typeof(Expression<>).MakeGenericType(funcType);
var method = typeof(Queryable).GetMethod(nameof(Queryable.Where), new Type[] { firstParam, secondParam });

Categories